linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] drm/nouveau/kms/nv50-: make base917c_format static
@ 2019-10-08 11:07 Ben Dooks
  2019-10-08 11:07 ` [PATCH 2/3] drm/nouveau/kms/nv50-: make unexported items static Ben Dooks
  2019-10-08 11:07 ` [PATCH 3/3] drm/nouveau/kms/nv50-: include n50_display.h for nv50_display_create Ben Dooks
  0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2019-10-08 11:07 UTC (permalink / raw)
  To: linux-kernel, nouveau, dri-devel
  Cc: Ben Skeggs, David Airlie, Daniel Vetter, Ben Dooks

The base917c_format isn't exported, so make it static to
avoid the following warning:

drivers/gpu/drm/nouveau/dispnv50/base917c.c:26:1: warning: symbol 'base917c_format' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/gpu/drm/nouveau/dispnv50/base917c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/base917c.c b/drivers/gpu/drm/nouveau/dispnv50/base917c.c
index a1baed4fe0e9..ca260509a4f1 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/base917c.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/base917c.c
@@ -22,7 +22,7 @@
 #include "base.h"
 #include "atom.h"
 
-const u32
+static const u32
 base917c_format[] = {
 	DRM_FORMAT_C8,
 	DRM_FORMAT_XRGB8888,
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/3] drm/nouveau/kms/nv50-: make unexported items static
  2019-10-08 11:07 [PATCH 1/3] drm/nouveau/kms/nv50-: make base917c_format static Ben Dooks
@ 2019-10-08 11:07 ` Ben Dooks
  2019-10-08 11:07 ` [PATCH 3/3] drm/nouveau/kms/nv50-: include n50_display.h for nv50_display_create Ben Dooks
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2019-10-08 11:07 UTC (permalink / raw)
  To: linux-kernel, nouveau, dri-devel
  Cc: Ben Skeggs, David Airlie, Daniel Vetter, Ben Dooks

Make functions that are not used directly outside the file
they are in static to avoid the following warnings:

drivers/gpu/drm/nouveau/dispnv50/headc57d.c:73:1: warning: symbol 'headc57d_olut_clr' was not declared. Should it be static?
drivers/gpu/drm/nouveau/dispnv50/headc57d.c:85:1: warning: symbol 'headc57d_olut_set' was not declared. Should it be static?
drivers/gpu/drm/nouveau/dispnv50/headc57d.c:155:1: warning: symbol 'headc57d_olut' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/gpu/drm/nouveau/dispnv50/headc57d.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/headc57d.c b/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
index 32a7f9e85fb0..f3d46276a7c4 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
@@ -69,7 +69,7 @@ headc57d_procamp(struct nv50_head *head, struct nv50_head_atom *asyh)
 	}
 }
 
-void
+static void
 headc57d_olut_clr(struct nv50_head *head)
 {
 	struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->core->chan;
@@ -81,7 +81,7 @@ headc57d_olut_clr(struct nv50_head *head)
 	}
 }
 
-void
+static void
 headc57d_olut_set(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
 	struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->core->chan;
@@ -151,7 +151,7 @@ headc57d_olut_load(struct drm_color_lut *in, int size, void __iomem *mem)
 	writew(readw(mem - 4), mem + 4);
 }
 
-void
+static void
 headc57d_olut(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
 	asyh->olut.mode = 2; /* DIRECT10 */
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 3/3] drm/nouveau/kms/nv50-: include n50_display.h for nv50_display_create
  2019-10-08 11:07 [PATCH 1/3] drm/nouveau/kms/nv50-: make base917c_format static Ben Dooks
  2019-10-08 11:07 ` [PATCH 2/3] drm/nouveau/kms/nv50-: make unexported items static Ben Dooks
@ 2019-10-08 11:07 ` Ben Dooks
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2019-10-08 11:07 UTC (permalink / raw)
  To: linux-kernel, nouveau, dri-devel
  Cc: Ben Skeggs, David Airlie, Daniel Vetter, Ben Dooks

Include n50_display.h for the definition of nv50_display_create to
fix the warning (and remove the now non-exported definitions in the
n50_display.h to allow the code to build):

drivers/gpu/drm/nouveau/dispnv50/disp.c:2297:1: warning: symbol 'nv50_display_create' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 ++
 drivers/gpu/drm/nouveau/nv50_display.h  | 3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index b46be8a091e9..f7774cc927d8 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -53,6 +53,8 @@
 #include "nouveau_fence.h"
 #include "nouveau_fbcon.h"
 
+#include "nv50_display.h"
+
 #include <subdev/bios/dp.h>
 
 /******************************************************************************
diff --git a/drivers/gpu/drm/nouveau/nv50_display.h b/drivers/gpu/drm/nouveau/nv50_display.h
index fbd3b15583bc..2421401d1263 100644
--- a/drivers/gpu/drm/nouveau/nv50_display.h
+++ b/drivers/gpu/drm/nouveau/nv50_display.h
@@ -31,7 +31,4 @@
 #include "nouveau_reg.h"
 
 int  nv50_display_create(struct drm_device *);
-void nv50_display_destroy(struct drm_device *);
-int  nv50_display_init(struct drm_device *);
-void nv50_display_fini(struct drm_device *);
 #endif /* __NV50_DISPLAY_H__ */
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-08 11:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 11:07 [PATCH 1/3] drm/nouveau/kms/nv50-: make base917c_format static Ben Dooks
2019-10-08 11:07 ` [PATCH 2/3] drm/nouveau/kms/nv50-: make unexported items static Ben Dooks
2019-10-08 11:07 ` [PATCH 3/3] drm/nouveau/kms/nv50-: include n50_display.h for nv50_display_create Ben Dooks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).