* [PATCH] watchdog: cadence: Do not show error in case of deferred probe
@ 2019-10-08 14:29 Michal Simek
2019-10-08 15:22 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2019-10-08 14:29 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Guenter Roeck, Wim Van Sebroeck, linux-watchdog
There is no reason to show error message if clocks are not ready yet.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/watchdog/cadence_wdt.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
index 76d855ce25f3..672b184da875 100644
--- a/drivers/watchdog/cadence_wdt.c
+++ b/drivers/watchdog/cadence_wdt.c
@@ -335,8 +335,10 @@ static int cdns_wdt_probe(struct platform_device *pdev)
wdt->clk = devm_clk_get(dev, NULL);
if (IS_ERR(wdt->clk)) {
- dev_err(dev, "input clock not found\n");
- return PTR_ERR(wdt->clk);
+ ret = PTR_ERR(wdt->clk);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "input clock not found\n");
+ return ret;
}
ret = clk_prepare_enable(wdt->clk);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: cadence: Do not show error in case of deferred probe
2019-10-08 14:29 [PATCH] watchdog: cadence: Do not show error in case of deferred probe Michal Simek
@ 2019-10-08 15:22 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2019-10-08 15:22 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-kernel, monstr, git, Wim Van Sebroeck, linux-watchdog
On Tue, Oct 08, 2019 at 04:29:10PM +0200, Michal Simek wrote:
> There is no reason to show error message if clocks are not ready yet.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> drivers/watchdog/cadence_wdt.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 76d855ce25f3..672b184da875 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -335,8 +335,10 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>
> wdt->clk = devm_clk_get(dev, NULL);
> if (IS_ERR(wdt->clk)) {
> - dev_err(dev, "input clock not found\n");
> - return PTR_ERR(wdt->clk);
> + ret = PTR_ERR(wdt->clk);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "input clock not found\n");
> + return ret;
> }
>
> ret = clk_prepare_enable(wdt->clk);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-08 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 14:29 [PATCH] watchdog: cadence: Do not show error in case of deferred probe Michal Simek
2019-10-08 15:22 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).