From: Brian Starkey <Brian.Starkey@arm.com>
To: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Russell King <linux@armlinux.org.uk>,
Maxime Ripard <mripard@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
nd <nd@arm.com>, Sean Paul <sean@poorly.run>
Subject: Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints
Date: Thu, 17 Oct 2019 08:20:56 +0000 [thread overview]
Message-ID: <20191017082043.bpiuvfr3r4jngxtu@DESKTOP-E1NTVVP.localdomain> (raw)
In-Reply-To: <20191017030752.GA3109@jamwan02-TSP300>
On Thu, Oct 17, 2019 at 03:07:59AM +0000, james qian wang (Arm Technology China) wrote:
> On Wed, Oct 16, 2019 at 04:22:07PM +0000, Brian Starkey wrote:
> >
> > If James is strongly against merging this, maybe we just swap
> > wholesale to bridge? But for me, the pragmatic approach would be this
> > stop-gap.
> >
>
> This is a good idea, and I vote +ULONG_MAX :)
>
> and I also checked tda998x driver, it supports bridge. so swap the
> wholesale to brige is perfect. :)
>
Well, as Mihail wrote, it's definitely not perfect.
Today, if you rmmod tda998x with the DPU driver still loaded,
everything will be unbound gracefully.
If we swap to bridge, then rmmod'ing tda998x (or any other bridge
driver the DPU is using) with the DPU driver still loaded will result
in a crash.
So, there really are proper benefits to sticking with the component
code for tda998x, which is why I'd like to understand why you're so
against this patch?
Thanks,
-Brian
next prev parent reply other threads:[~2019-10-17 8:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 14:34 [PATCH 0/3] drm/komeda: Support for drm_bridge endpoints Mihail Atanassov
2019-10-04 14:34 ` [PATCH 1/3] drm/komeda: Consolidate struct komeda_drv allocations Mihail Atanassov
2019-10-04 14:34 ` [PATCH 2/3] drm/komeda: Memory manage struct komeda_drv in probe/remove Mihail Atanassov
2019-10-04 14:34 ` [RFC PATCH 3/3] drm/komeda: Allow non-component drm_bridge only endpoints Mihail Atanassov
2019-10-09 5:54 ` [RFC,3/3] " james qian wang (Arm Technology China)
2019-10-16 15:51 ` Mihail Atanassov
2019-10-16 16:22 ` Brian Starkey
2019-10-17 3:07 ` james qian wang (Arm Technology China)
2019-10-17 8:20 ` Brian Starkey [this message]
2019-10-17 10:21 ` james qian wang (Arm Technology China)
2019-10-17 10:48 ` Brian Starkey
2019-10-17 11:41 ` Russell King - ARM Linux admin
2019-10-18 6:57 ` james qian wang (Arm Technology China)
2019-10-18 9:12 ` Brian Starkey
2019-10-22 8:42 ` Daniel Vetter
2019-10-22 8:48 ` Russell King - ARM Linux admin
2019-10-22 8:50 ` Daniel Vetter
2019-10-22 14:42 ` Russell King - ARM Linux admin
2019-10-22 14:53 ` Russell King - ARM Linux admin
2019-10-24 8:03 ` Mihail Atanassov
2019-10-24 5:21 ` james qian wang (Arm Technology China)
2019-10-18 6:38 ` james qian wang (Arm Technology China)
2019-10-18 11:01 ` Mihail Atanassov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017082043.bpiuvfr3r4jngxtu@DESKTOP-E1NTVVP.localdomain \
--to=brian.starkey@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Mihail.Atanassov@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.qian.wang@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mripard@kernel.org \
--cc=nd@arm.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).