From: Shawn Guo <shawnguo@kernel.org>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/11] ARM: dts: imx6ul-kontron-n6x1x-s: Disable the snvs-poweroff driver
Date: Mon, 4 Nov 2019 15:43:47 +0800 [thread overview]
Message-ID: <20191104074346.GT24620@dragon> (raw)
In-Reply-To: <20191031142112.12431-10-frieder.schrempf@kontron.de>
On Thu, Oct 31, 2019 at 02:24:27PM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> The snvs-poweroff driver can power off the system by pulling the
> PMIC_ON_REQ signal low, to let the PMIC disable the power.
> The Kontron SoMs do not have this signal connected, so let's remove
> the node.
>
> This seems to fix a real issue when the signal is asserted at
> poweroff, but not actually causing the power to turn off. It was
> observed, that in this case the system would not shut down properly.
I do not quite follow on this. How does disabling snvs_poweroff fix the
issue? The root cause of system not shut down properly seems to be that
PMIC doesn't shut down power. This looks like a clean-up rather than
bug fix.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards")
If you think this is really a bug fix, it should be applied to the file
before renaming rather than the one after renaming.
Shawn
> ---
> arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi
> index e18a8bd239be..4682a79f5b23 100644
> --- a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi
> @@ -158,10 +158,6 @@
> status = "okay";
> };
>
> -&snvs_poweroff {
> - status = "okay";
> -};
> -
> &uart1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart1>;
> --
> 2.17.1
next prev parent reply other threads:[~2019-11-04 7:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 14:23 [PATCH v3 00/11] Add support for more Kontron i.MX6UL/ULL SoMs and boards Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 01/11] ARM: dts: imx6ul-kontron-n6310: Move common SoM nodes to a separate file Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 02/11] ARM: dts: Add support for two more Kontron SoMs N6311 and N6411 Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 03/11] ARM: dts: imx6ul-kontron-n6310-s: Move common nodes to a separate file Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 04/11] ARM: dts: Add support for two more Kontron evalkit boards 'N6311 S' and 'N6411 S' Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 05/11] ARM: dts: imx6ul-kontron-n6x1x: Add 'chosen' node with 'stdout-path' Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 06/11] ARM: dts: imx6ul-kontron-n6x1x-s: Specify bus-width for SD card and eMMC Schrempf Frieder
2019-11-04 7:29 ` Shawn Guo
2019-11-04 7:40 ` Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 07/11] ARM: dts: imx6ul-kontron-n6x1x-s: Add vbus-supply and overcurrent polarity to usb nodes Schrempf Frieder
2019-11-04 7:31 ` Shawn Guo
2019-11-04 7:53 ` Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 08/11] ARM: dts: imx6ul-kontron-n6x1x-s: Remove an obsolete comment and fix indentation Schrempf Frieder
2019-11-04 7:33 ` Shawn Guo
2019-11-04 7:53 ` Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 09/11] ARM: dts: imx6ul-kontron-n6x1x-s: Disable the snvs-poweroff driver Schrempf Frieder
2019-11-04 7:43 ` Shawn Guo [this message]
2019-11-04 8:06 ` Schrempf Frieder
2019-11-04 11:18 ` Schrempf Frieder
2019-11-04 12:45 ` Shawn Guo
2019-11-04 13:14 ` Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 10/11] dt-bindings: arm: fsl: Add more Kontron i.MX6UL/ULL compatibles Schrempf Frieder
2019-10-31 14:24 ` [PATCH v3 11/11] MAINTAINERS: Add an entry for Kontron Electronics ARM board support Schrempf Frieder
2019-11-04 7:45 ` Shawn Guo
2019-11-04 8:16 ` Schrempf Frieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104074346.GT24620@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).