Re: [PATCH v3 07/11] ARM: dts: imx6ul-kontron-n6x1x-s: Add vbus-supply and overcurrent polarity to usb nodes

From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 07/11] ARM: dts: imx6ul-kontron-n6x1x-s: Add vbus-supply and overcurrent polarity to usb nodes
Date: Mon, 4 Nov 2019 07:53:09 +0000	[thread overview]
Message-ID: <77f6c71e-19ee-50c6-ecbd-c3547f0c4e84@kontron.de> (raw)
In-Reply-To: <20191104073151.GR24620@dragon>

On 04.11.19 08:31, Shawn Guo wrote:
> On Thu, Oct 31, 2019 at 02:24:21PM +0000, Schrempf Frieder wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> To silence the warnings shown by the driver at boot time, we add a
>> fixed regulator for the 5V supply of usbotg2 and specify the polarity
>> of the overcurrent signal for usbotg1.
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards")
> 
> I do not think it's a bug fix, so the Fixes tag doesn't really apply.

I guess you're right. It only prevents warnings at boot time and 
functionality is not broken. I think I had a wrong understanding of the 
Fixes tag and need to reread the docs...

> 
> Shawn
> 
>> ---
>>   arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi
>> index 2299cad900af..d3eb21aa9014 100644
>> --- a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi
>> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi
>> @@ -45,6 +45,13 @@
>>   		regulator-max-microvolt = <3300000>;
>>   	};
>>   
>> +	reg_5v: regulator-5v {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "5v";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +	};
>> +
>>   	reg_usb_otg1_vbus: regulator-usb-otg1-vbus {
>>   		compatible = "regulator-fixed";
>>   		regulator-name = "usb_otg1_vbus";
>> @@ -191,6 +198,7 @@
>>   	srp-disable;
>>   	hnp-disable;
>>   	adp-disable;
>> +	over-current-active-low;
>>   	vbus-supply = <&reg_usb_otg1_vbus>;
>>   	status = "okay";
>>   };
>> @@ -198,6 +206,7 @@
>>   &usbotg2 {
>>   	dr_mode = "host";
>>   	disable-over-current;
>> +	vbus-supply = <&reg_5v>;
>>   	status = "okay";
>>   };
>>   
>> -- 
>> 2.17.1
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 