From: Stephen Boyd <sboyd@kernel.org>
To: Chengyu Song <csong@cs.ucr.edu>,
Michael Turquette <mturquette@baylibre.com>,
Yizhuo Zhai <yzhai003@ucr.edu>, Zhiyun Qian <zhiyunq@cs.ucr.edu>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Potential uninitialized variable "reg" in clk: axi-clkgen
Date: Fri, 08 Nov 2019 14:28:38 -0800 [thread overview]
Message-ID: <20191108222839.07D7120865@mail.kernel.org> (raw)
In-Reply-To: <CABvMjLSomcm5Yi8b8YNgJGkQkc++qdCS_SQvKfmsV0CfS+GLuA@mail.gmail.com>
Quoting Yizhuo Zhai (2019-10-09 17:55:06)
> Hi All:
> drivers/clk/clk-axi-clkgen.c:
>
> Inside function axi_clkgen_recalc_rate(), variable "reg" could be
> uninitialized if axi_clkgen_mmcm_read() fails. However, "reg" is used
> to decide the control flow later in the if statement, which is
> potentially unsafe.
>
> The patch for this case is not easy since the error return is not an
> acceptable return value for axi_clkgen_recalc_rate().
>
I think we will do nothing unless you send some sort of patch. Sorry.
prev parent reply other threads:[~2019-11-08 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 0:55 Potential uninitialized variable "reg" in clk: axi-clkgen Yizhuo Zhai
2019-11-08 22:28 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108222839.07D7120865@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=csong@cs.ucr.edu \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=yzhai003@ucr.edu \
--cc=zhiyunq@cs.ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).