From: Yizhuo Zhai <yzhai003@ucr.edu>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhiyun Qian <zhiyunq@cs.ucr.edu>, Chengyu Song <csong@cs.ucr.edu>
Subject: Potential uninitialized variable "reg" in clk: axi-clkgen
Date: Wed, 9 Oct 2019 17:55:06 -0700 [thread overview]
Message-ID: <CABvMjLSomcm5Yi8b8YNgJGkQkc++qdCS_SQvKfmsV0CfS+GLuA@mail.gmail.com> (raw)
Hi All:
drivers/clk/clk-axi-clkgen.c:
Inside function axi_clkgen_recalc_rate(), variable "reg" could be
uninitialized if axi_clkgen_mmcm_read() fails. However, "reg" is used
to decide the control flow later in the if statement, which is
potentially unsafe.
The patch for this case is not easy since the error return is not an
acceptable return value for axi_clkgen_recalc_rate().
--
Kind Regards,
Yizhuo Zhai
Computer Science, Graduate Student
University of California, Riverside
next reply other threads:[~2019-10-10 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 0:55 Yizhuo Zhai [this message]
2019-11-08 22:28 ` Potential uninitialized variable "reg" in clk: axi-clkgen Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABvMjLSomcm5Yi8b8YNgJGkQkc++qdCS_SQvKfmsV0CfS+GLuA@mail.gmail.com \
--to=yzhai003@ucr.edu \
--cc=csong@cs.ucr.edu \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=zhiyunq@cs.ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).