* [RFC PATCH linux-next] vsock/vmci: vmci_vsock_cb_host_called can be static
2019-11-18 16:56 [linux-next:master 11698/12822] drivers/misc/vmw_vmci/vmci_driver.c:33:6: sparse: sparse: symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static? kbuild test robot
@ 2019-11-18 16:56 ` kbuild test robot
2019-11-19 8:06 ` Stefano Garzarella
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-11-18 16:56 UTC (permalink / raw)
To: Stefano Garzarella
Cc: kbuild-all, Arnd Bergmann, Greg Kroah-Hartman, Alexios Zavras,
Thomas Gleixner, linux-kernel
Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
vmci_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c
index 95fed4664a2d2..cbb706dabede9 100644
--- a/drivers/misc/vmw_vmci/vmci_driver.c
+++ b/drivers/misc/vmw_vmci/vmci_driver.c
@@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized;
static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */
static vmci_vsock_cb vmci_vsock_transport_cb;
-bool vmci_vsock_cb_host_called;
+static bool vmci_vsock_cb_host_called;
/*
* vmci_get_context_id() - Gets the current context ID.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [linux-next:master 11698/12822] drivers/misc/vmw_vmci/vmci_driver.c:33:6: sparse: sparse: symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?
@ 2019-11-18 16:56 kbuild test robot
2019-11-18 16:56 ` [RFC PATCH linux-next] vsock/vmci: vmci_vsock_cb_host_called can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-11-18 16:56 UTC (permalink / raw)
To: Stefano Garzarella
Cc: kbuild-all, Arnd Bergmann, Greg Kroah-Hartman, Thomas Gleixner,
Allison Randal, Kate Stewart, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 519ead8f6a3215406afc6e56c596388a690f2edc
commit: b1bba80a4376aef34de2b57bfb8834bd095703ed [11698/12822] vsock/vmci: register vmci_transport only when VMCI guest/host are active
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-32-g233d4e1-dirty
git checkout b1bba80a4376aef34de2b57bfb8834bd095703ed
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/misc/vmw_vmci/vmci_driver.c:33:6: sparse: sparse: symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH linux-next] vsock/vmci: vmci_vsock_cb_host_called can be static
2019-11-18 16:56 ` [RFC PATCH linux-next] vsock/vmci: vmci_vsock_cb_host_called can be static kbuild test robot
@ 2019-11-19 8:06 ` Stefano Garzarella
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2019-11-19 8:06 UTC (permalink / raw)
To: kbuild test robot, davem
Cc: kbuild-all, Arnd Bergmann, Greg Kroah-Hartman, Alexios Zavras,
Thomas Gleixner, linux-kernel
On Tue, Nov 19, 2019 at 12:56:15AM +0800, kbuild test robot wrote:
>
> Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
> vmci_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c
> index 95fed4664a2d2..cbb706dabede9 100644
> --- a/drivers/misc/vmw_vmci/vmci_driver.c
> +++ b/drivers/misc/vmw_vmci/vmci_driver.c
> @@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized;
>
> static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */
> static vmci_vsock_cb vmci_vsock_transport_cb;
> -bool vmci_vsock_cb_host_called;
> +static bool vmci_vsock_cb_host_called;
>
> /*
> * vmci_get_context_id() - Gets the current context ID.
>
My fault!
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-19 8:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 16:56 [linux-next:master 11698/12822] drivers/misc/vmw_vmci/vmci_driver.c:33:6: sparse: sparse: symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static? kbuild test robot
2019-11-18 16:56 ` [RFC PATCH linux-next] vsock/vmci: vmci_vsock_cb_host_called can be static kbuild test robot
2019-11-19 8:06 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).