From: Mark Brown <broonie@kernel.org>
To: Siddharth Kapoor <ksiddharth@google.com>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: Kernel panic on Google Pixel devices due to regulator patch
Date: Wed, 18 Dec 2019 11:34:58 +0000 [thread overview]
Message-ID: <20191218113458.GA3219@sirena.org.uk> (raw)
In-Reply-To: <CAJRo92+eD9F6Q60yVY2PfwaPWO_8Dts8QwH7mhpJaem7SpLihg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]
On Tue, Dec 17, 2019 at 11:51:55PM +0800, Siddharth Kapoor wrote:
> I would like to share a concern with the regulator patch which is part of
> 4.9.196 LTS kernel.
That's an *extremely* old kernel.
> https://lore.kernel.org/lkml/20190904124250.25844-1-broonie@kernel.org/
That's the patch "[PATCH] regulator: Defer init completion for a while
after late_initcall" which defers disabling of idle regulators for a
while.
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
> We have reverted the patch in Pixel kernels and would like you to look into
> this and consider reverting it upstream as well.
I've got nothing to do with the stable kernels so there's nothing I can
do here, sorry. However if this is triggering anything it's almost
certainly some kind of timing issue (this code isn't new, it's just
being run a bit later) and is only currently working through luck so I
do strongly recommend trying to figure out the actual problem since it's
liable to come back and bite you later - we did find one buggy driver in
mainline as a result of this change, it's possible you've got another
one.
Possibly your GPU supplies need to be flagged as always on, possibly
your GPU driver is forgetting to enable some supplies it needs, or
possibly there's a missing always-on constraint on one of the regulators
depending on how the driver expects this to work (if it's a proprietary
driver it shouldn't be using the regulator API itself). I'm quite
surprised you've not seen any issue before given that the supplies would
still be being disabled earlier.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next parent reply other threads:[~2019-12-18 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJRo92+eD9F6Q60yVY2PfwaPWO_8Dts8QwH7mhpJaem7SpLihg@mail.gmail.com>
2019-12-18 11:34 ` Mark Brown [this message]
2019-12-18 12:21 ` Kernel panic on Google Pixel devices due to regulator patch Greg KH
2019-12-18 13:11 ` Mark Brown
2019-12-18 14:22 ` Greg KH
2019-12-18 16:18 ` Mark Brown
2019-12-18 16:24 ` Greg KH
2019-12-18 17:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218113458.GA3219@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ksiddharth@google.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).