From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Siddharth Kapoor <ksiddharth@google.com>,
lee.jones@linaro.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: Kernel panic on Google Pixel devices due to regulator patch
Date: Wed, 18 Dec 2019 13:21:57 +0100 [thread overview]
Message-ID: <20191218122157.GA17086@kroah.com> (raw)
In-Reply-To: <20191218113458.GA3219@sirena.org.uk>
On Wed, Dec 18, 2019 at 11:34:58AM +0000, Mark Brown wrote:
> On Tue, Dec 17, 2019 at 11:51:55PM +0800, Siddharth Kapoor wrote:
>
> > I would like to share a concern with the regulator patch which is part of
> > 4.9.196 LTS kernel.
>
> That's an *extremely* old kernel.
It is, but it's the latest stable kernel (well close to), and your patch
was tagged by you to be backported to here, so if there's a problem with
a stable branch, I want to know about it as I don't want to see
regressions happen in it.
> > https://lore.kernel.org/lkml/20190904124250.25844-1-broonie@kernel.org/
>
> That's the patch "[PATCH] regulator: Defer init completion for a while
> after late_initcall" which defers disabling of idle regulators for a
> while.
>
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.
>
> > We have reverted the patch in Pixel kernels and would like you to look into
> > this and consider reverting it upstream as well.
>
> I've got nothing to do with the stable kernels so there's nothing I can
> do here, sorry.
Should I revert it everywhere? This patch reads as it should be fixing
problems, not causing them :)
> However if this is triggering anything it's almost
> certainly some kind of timing issue (this code isn't new, it's just
> being run a bit later) and is only currently working through luck so I
> do strongly recommend trying to figure out the actual problem since it's
> liable to come back and bite you later - we did find one buggy driver in
> mainline as a result of this change, it's possible you've got another
> one.
>
> Possibly your GPU supplies need to be flagged as always on, possibly
> your GPU driver is forgetting to enable some supplies it needs, or
> possibly there's a missing always-on constraint on one of the regulators
> depending on how the driver expects this to work (if it's a proprietary
> driver it shouldn't be using the regulator API itself). I'm quite
> surprised you've not seen any issue before given that the supplies would
> still be being disabled earlier.
Timing "luck" is probably something we shouldn't be messing with in
stable kernels. How about I revert this for the 4.14 and older releases
and let new devices deal with the timing issues when they are brought up
on new hardware?
thanks,
greg k-h
next prev parent reply other threads:[~2019-12-18 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJRo92+eD9F6Q60yVY2PfwaPWO_8Dts8QwH7mhpJaem7SpLihg@mail.gmail.com>
2019-12-18 11:34 ` Kernel panic on Google Pixel devices due to regulator patch Mark Brown
2019-12-18 12:21 ` Greg KH [this message]
2019-12-18 13:11 ` Mark Brown
2019-12-18 14:22 ` Greg KH
2019-12-18 16:18 ` Mark Brown
2019-12-18 16:24 ` Greg KH
2019-12-18 17:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218122157.GA17086@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=ksiddharth@google.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).