* [PATCH next] drivers: net: cisco_hdlc: use __func__ in debug message
@ 2020-01-07 9:33 Chen Zhou
2020-01-07 21:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2020-01-07 9:33 UTC (permalink / raw)
To: khc, davem; +Cc: netdev, linux-kernel, chenzhou10
Use __func__ to print the function name instead of hard coded string.
BTW, replace printk(KERN_DEBUG, ...) with netdev_dbg.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/net/wan/hdlc_cisco.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index a030f5a..d8cba36 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -75,7 +75,7 @@ static int cisco_hard_header(struct sk_buff *skb, struct net_device *dev,
{
struct hdlc_header *data;
#ifdef DEBUG_HARD_HEADER
- printk(KERN_DEBUG "%s: cisco_hard_header called\n", dev->name);
+ netdev_dbg(dev, "%s called\n", __func__);
#endif
skb_push(skb, sizeof(struct hdlc_header));
@@ -101,7 +101,7 @@ static void cisco_keepalive_send(struct net_device *dev, u32 type,
skb = dev_alloc_skb(sizeof(struct hdlc_header) +
sizeof(struct cisco_packet));
if (!skb) {
- netdev_warn(dev, "Memory squeeze on cisco_keepalive_send()\n");
+ netdev_warn(dev, "Memory squeeze on %s()\n", __func__);
return;
}
skb_reserve(skb, 4);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] drivers: net: cisco_hdlc: use __func__ in debug message
2020-01-07 9:33 [PATCH next] drivers: net: cisco_hdlc: use __func__ in debug message Chen Zhou
@ 2020-01-07 21:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-01-07 21:33 UTC (permalink / raw)
To: chenzhou10; +Cc: khc, netdev, linux-kernel
From: Chen Zhou <chenzhou10@huawei.com>
Date: Tue, 7 Jan 2020 17:33:46 +0800
> Use __func__ to print the function name instead of hard coded string.
> BTW, replace printk(KERN_DEBUG, ...) with netdev_dbg.
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-07 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 9:33 [PATCH next] drivers: net: cisco_hdlc: use __func__ in debug message Chen Zhou
2020-01-07 21:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).