* [PATCH] fs: omfs: use kmemdup
@ 2020-01-08 11:16 Chen Zhou
0 siblings, 0 replies; only message in thread
From: Chen Zhou @ 2020-01-08 11:16 UTC (permalink / raw)
To: me; +Cc: linux-karma-devel, linux-kernel, chenzhou10
Fix memdup.cocci warnings:
./fs/omfs/inode.c:366:9-16: WARNING opportunity for kmemdup
Use kmemdup rather than duplicating its implementation.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
fs/omfs/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index b76ec6b..8867cef 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
bh = sb_bread(sb, block++);
if (!bh)
goto nomem_free;
- *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
+ *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
if (!*ptr) {
brelse(bh);
goto nomem_free;
}
- memcpy(*ptr, bh->b_data, sb->s_blocksize);
if (count < sb->s_blocksize)
memset((void *)*ptr + count, 0xff,
sb->s_blocksize - count);
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-08 11:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 11:16 [PATCH] fs: omfs: use kmemdup Chen Zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).