[PATCH] bus: tegra-aconnect: remove PM_CLK dependency

[PATCH] bus: tegra-aconnect: remove PM_CLK dependency

[Sameer Pujar]

aconnect bus driver does not use pm-clk interface now and hence the
dependency is removed from Kconfig.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 drivers/bus/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 1851112..4587ef2 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -128,7 +128,6 @@ config TEGRA_ACONNECT
 	tristate "Tegra ACONNECT Bus Driver"
 	depends on ARCH_TEGRA_210_SOC
 	depends on OF && PM
-	select PM_CLK
 	help
 	  Driver for the Tegra ACONNECT bus which is used to interface with
 	  the devices inside the Audio Processing Engine (APE) for Tegra210.
-- 
2.7.4

Re: [PATCH] bus: tegra-aconnect: remove PM_CLK dependency

[Jon Hunter]

On 20/06/2019 16:51, Sameer Pujar wrote:
> aconnect bus driver does not use pm-clk interface now and hence the
> dependency is removed from Kconfig.
> 
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
>  drivers/bus/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 1851112..4587ef2 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -128,7 +128,6 @@ config TEGRA_ACONNECT
>  	tristate "Tegra ACONNECT Bus Driver"
>  	depends on ARCH_TEGRA_210_SOC
>  	depends on OF && PM
> -	select PM_CLK
>  	help
>  	  Driver for the Tegra ACONNECT bus which is used to interface with
>  	  the devices inside the Audio Processing Engine (APE) for Tegra210.

Thanks. We should probably populate the 'Fixes:' tag for this to show
which commit this fixes. Otherwise ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic

Re: [PATCH] bus: tegra-aconnect: remove PM_CLK dependency

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

On Thu, Jun 20, 2019 at 05:02:27PM +0100, Jon Hunter wrote:
> 
> On 20/06/2019 16:51, Sameer Pujar wrote:
> > aconnect bus driver does not use pm-clk interface now and hence the
> > dependency is removed from Kconfig.
> > 
> > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > ---
> >  drivers/bus/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> > index 1851112..4587ef2 100644
> > --- a/drivers/bus/Kconfig
> > +++ b/drivers/bus/Kconfig
> > @@ -128,7 +128,6 @@ config TEGRA_ACONNECT
> >  	tristate "Tegra ACONNECT Bus Driver"
> >  	depends on ARCH_TEGRA_210_SOC
> >  	depends on OF && PM
> > -	select PM_CLK
> >  	help
> >  	  Driver for the Tegra ACONNECT bus which is used to interface with
> >  	  the devices inside the Audio Processing Engine (APE) for Tegra210.
> 
> Thanks. We should probably populate the 'Fixes:' tag for this to show
> which commit this fixes. Otherwise ...
> 
> Acked-by: Jon Hunter <jonathanh@nvidia.com>

Looks like this was never applied. I don't recollect that there was a
specific reason why we shouldn't, so I went ahead and applied this after
adding:

Fixes: 0d7dab926130 ("bus: tegra-aconnect: use devm_clk_*() helpers")

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]