* [PATCH next] power: suppy: ucs1002: Make the symbol 'ucs1002_regulator_enable' static
@ 2019-12-20 9:41 Chen Wandun
2020-01-15 20:52 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Chen Wandun @ 2019-12-20 9:41 UTC (permalink / raw)
To: sebastian.reichel, l.stach, linux-pm, linux-kernel; +Cc: chenwandun
Fix the following sparse warning:
drivers/power/supply/ucs1002_power.c:492:5: warning: symbol 'ucs1002_regulator_enable' was not declared. Should it be static?
Fixes: a3d70dacc727 ("power: suppy: ucs1002: disable power when maxcurrent is 0")
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
drivers/power/supply/ucs1002_power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c
index 0ca80d00b80a..cdb9a23d825f 100644
--- a/drivers/power/supply/ucs1002_power.c
+++ b/drivers/power/supply/ucs1002_power.c
@@ -489,7 +489,7 @@ static irqreturn_t ucs1002_alert_irq(int irq, void *data)
return IRQ_HANDLED;
}
-int ucs1002_regulator_enable(struct regulator_dev *rdev)
+static int ucs1002_regulator_enable(struct regulator_dev *rdev)
{
struct ucs1002_info *info = rdev_get_drvdata(rdev);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] power: suppy: ucs1002: Make the symbol 'ucs1002_regulator_enable' static
2019-12-20 9:41 [PATCH next] power: suppy: ucs1002: Make the symbol 'ucs1002_regulator_enable' static Chen Wandun
@ 2020-01-15 20:52 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2020-01-15 20:52 UTC (permalink / raw)
To: Chen Wandun; +Cc: l.stach, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
Hi,
Thanks, queued.
-- Sebastian
On Fri, Dec 20, 2019 at 05:41:44PM +0800, Chen Wandun wrote:
> Fix the following sparse warning:
>
> drivers/power/supply/ucs1002_power.c:492:5: warning: symbol 'ucs1002_regulator_enable' was not declared. Should it be static?
>
> Fixes: a3d70dacc727 ("power: suppy: ucs1002: disable power when maxcurrent is 0")
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
> ---
> drivers/power/supply/ucs1002_power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c
> index 0ca80d00b80a..cdb9a23d825f 100644
> --- a/drivers/power/supply/ucs1002_power.c
> +++ b/drivers/power/supply/ucs1002_power.c
> @@ -489,7 +489,7 @@ static irqreturn_t ucs1002_alert_irq(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -int ucs1002_regulator_enable(struct regulator_dev *rdev)
> +static int ucs1002_regulator_enable(struct regulator_dev *rdev)
> {
> struct ucs1002_info *info = rdev_get_drvdata(rdev);
>
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-15 20:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-20 9:41 [PATCH next] power: suppy: ucs1002: Make the symbol 'ucs1002_regulator_enable' static Chen Wandun
2020-01-15 20:52 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).