* [PATCH] phy: ti: j721e-wiz: Fix build error without CONFIG_OF_ADDRESS
@ 2020-01-17 21:23 Kishon Vijay Abraham I
2020-01-17 23:01 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2020-01-17 21:23 UTC (permalink / raw)
To: Greg Kroah-Hartman, Kishon Vijay Abraham I; +Cc: linux-kernel, Hongbo Yao
From: Hongbo Yao <yaohongbo@huawei.com>
If CONFIG_OF_ADDRESS is not set and COMPILE_TEST=y, the following
error is seen while building phy-j721e-wiz.c
drivers/phy/ti/phy-j721e-wiz.o: In function `wiz_remove':
phy-j721e-wiz.c:(.text+0x1a): undefined reference to
`of_platform_device_destroy'
Fix the config dependency for PHY_J721E_WIZ here.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC")
Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
index 3a1d3887c99c..6dbe9d0b9ff3 100644
--- a/drivers/phy/ti/Kconfig
+++ b/drivers/phy/ti/Kconfig
@@ -36,6 +36,7 @@ config PHY_AM654_SERDES
config PHY_J721E_WIZ
tristate "TI J721E WIZ (SERDES Wrapper) support"
depends on OF && ARCH_K3 || COMPILE_TEST
+ depends on HAS_IOMEM && OF_ADDRESS
depends on COMMON_CLK
select GENERIC_PHY
select MULTIPLEXER
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: ti: j721e-wiz: Fix build error without CONFIG_OF_ADDRESS
2020-01-17 21:23 [PATCH] phy: ti: j721e-wiz: Fix build error without CONFIG_OF_ADDRESS Kishon Vijay Abraham I
@ 2020-01-17 23:01 ` Greg Kroah-Hartman
2020-01-17 23:09 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-17 23:01 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-kernel, Hongbo Yao
On Sat, Jan 18, 2020 at 02:53:10AM +0530, Kishon Vijay Abraham I wrote:
> From: Hongbo Yao <yaohongbo@huawei.com>
>
> If CONFIG_OF_ADDRESS is not set and COMPILE_TEST=y, the following
> error is seen while building phy-j721e-wiz.c
>
> drivers/phy/ti/phy-j721e-wiz.o: In function `wiz_remove':
> phy-j721e-wiz.c:(.text+0x1a): undefined reference to
> `of_platform_device_destroy'
>
> Fix the config dependency for PHY_J721E_WIZ here.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC")
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/phy/ti/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Want me to just take this directly in my tree so the build error goes
away?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: ti: j721e-wiz: Fix build error without CONFIG_OF_ADDRESS
2020-01-17 23:01 ` Greg Kroah-Hartman
@ 2020-01-17 23:09 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-17 23:09 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-kernel, Hongbo Yao
On Sat, Jan 18, 2020 at 12:01:02AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Jan 18, 2020 at 02:53:10AM +0530, Kishon Vijay Abraham I wrote:
> > From: Hongbo Yao <yaohongbo@huawei.com>
> >
> > If CONFIG_OF_ADDRESS is not set and COMPILE_TEST=y, the following
> > error is seen while building phy-j721e-wiz.c
> >
> > drivers/phy/ti/phy-j721e-wiz.o: In function `wiz_remove':
> > phy-j721e-wiz.c:(.text+0x1a): undefined reference to
> > `of_platform_device_destroy'
> >
> > Fix the config dependency for PHY_J721E_WIZ here.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Fixes: 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC")
> > Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> > drivers/phy/ti/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> Want me to just take this directly in my tree so the build error goes
> away?
Nevermind, I did :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-17 23:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 21:23 [PATCH] phy: ti: j721e-wiz: Fix build error without CONFIG_OF_ADDRESS Kishon Vijay Abraham I
2020-01-17 23:01 ` Greg Kroah-Hartman
2020-01-17 23:09 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).