* [PATCH 2/5] rcu: Add missing annotation for exit_tasks_rcu_start()
@ 2020-01-20 22:41 Jules Irenge
0 siblings, 0 replies; only message in thread
From: Jules Irenge @ 2020-01-20 22:41 UTC (permalink / raw)
To: paulmck
Cc: rostedt, mathieu.desnoyers, joel, rcu, iangshanlai, boqun.feng,
linux-kernel, Jules Irenge
Sparse reports a warning at exit_tasks_rcu_start(void)
|warning: context imbalance in exit_tasks_rcu_start() - wrong count at exit
To fix this, an __acquires(&tasks_rcu_exit_srcu) is added.
Given that exit_tasks_rcu_start() does actually call __srcu_read_lock().
This not only fixes the warning
but also improves on the readability of the code.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
kernel/rcu/update.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
index 1861103662db..99f4e617116b 100644
--- a/kernel/rcu/update.c
+++ b/kernel/rcu/update.c
@@ -801,7 +801,7 @@ static int __init rcu_spawn_tasks_kthread(void)
core_initcall(rcu_spawn_tasks_kthread);
/* Do the srcu_read_lock() for the above synchronize_srcu(). */
-void exit_tasks_rcu_start(void)
+void exit_tasks_rcu_start(void) __acquires(&tasks_rcu_exit_srcu)
{
preempt_disable();
current->rcu_tasks_idx = __srcu_read_lock(&tasks_rcu_exit_srcu);
--
2.24.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-20 22:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20 22:41 [PATCH 2/5] rcu: Add missing annotation for exit_tasks_rcu_start() Jules Irenge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).