From: Rob Herring <robh@kernel.org>
To: "André Draszik" <git@andred.net>
Cc: linux-kernel@vger.kernel.org, "André Draszik" <git@andred.net>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Aymen Sghaier" <aymen.sghaier@nxp.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey
Date: Thu, 6 Feb 2020 18:30:53 +0000 [thread overview]
Message-ID: <20200206183053.GA27553@bogus> (raw)
In-Reply-To: <20200130204516.4760-1-git@andred.net>
On Thu, 30 Jan 2020 20:45:14 +0000, =?UTF-8?q?Andr=C3=A9=20Draszik?= wrote:
> On i.MX7, the SNVS requires a clock. This is similar to the clock
> bound to the SNVS RTC node, but if the SNVS RTC driver isn't enabled,
> then SNVS doesn't work, and as such the pwrkey driver doesn't
> work (i.e. hangs the kernel, as the clock isn't enabled).
>
> Also see commit ec2a844ef7c1
> ("ARM: dts: imx7s: add snvs rtc clock")
> for a similar fix.
>
> Signed-off-by: André Draszik <git@andred.net>
> Cc: Anson Huang <Anson.Huang@nxp.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: "Horia Geantă" <horia.geanta@nxp.com>
> Cc: Aymen Sghaier <aymen.sghaier@nxp.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-crypto@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> ---
> .../devicetree/bindings/crypto/fsl-sec4.txt | 17 +++++++++++++++++
> arch/arm/boot/dts/imx7s.dtsi | 2 ++
> 2 files changed, 19 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-02-06 20:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 20:45 [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey André Draszik
2020-01-30 20:45 ` [PATCH 2/3] Input: snvs_pwrkey - enable snvs clock as needed André Draszik
2020-02-07 8:10 ` Horia Geanta
2020-02-09 22:38 ` Dmitry Torokhov
2020-02-10 2:03 ` Robin Gong
2020-02-10 6:33 ` Horia Geanta
2020-02-10 17:55 ` Dmitry Torokhov
2020-02-11 1:54 ` Robin Gong
2020-02-11 9:13 ` André Draszik
2020-02-12 0:58 ` Robin Gong
2020-01-30 20:45 ` [PATCH 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events André Draszik
2020-02-06 18:30 ` Rob Herring [this message]
2020-02-07 7:36 ` [PATCH 1/3] ARM: dts: imx7s: add snvs clock to pwrkey Horia Geanta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206183053.GA27553@bogus \
--to=robh@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=git@andred.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).