Re: [PATCH 08/13] dt-bindings: phy: Convert Calxeda ComboPHY binding to json-schema

From: Maxime Ripard <maxime@cerno.tech>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Robert Richter <rric@kernel.org>,
	soc@kernel.org, Jon Loeliger <jdl@jdl.com>,
	Mark Langsdorf <mlangsdo@redhat.com>,
	Eric Auger <eric.auger@redhat.com>, Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH 08/13] dt-bindings: phy: Convert Calxeda ComboPHY binding to json-schema
Date: Wed, 26 Feb 2020 19:26:37 +0100	[thread overview]
Message-ID: <20200226182637.npnurwcexvpgwmvo@gilmour.lan> (raw)
In-Reply-To: <20200226180901.89940-9-andre.przywara@arm.com>

[-- Attachment #1: Type: text/plain, Size: 2810 bytes --]

On Wed, Feb 26, 2020 at 06:08:56PM +0000, Andre Przywara wrote:
> Convert the Calxeda ComboPHY binding to DT schema format using
> json-schema.
> There is no driver in the Linux kernel matching the compatible
> string, but the nodes are parsed by the SATA driver, which links to them
> using its port-phys property.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  .../bindings/phy/calxeda-combophy.txt         | 17 -------
>  .../bindings/phy/calxeda-combophy.yaml        | 47 +++++++++++++++++++
>  2 files changed, 47 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/calxeda-combophy.txt
>  create mode 100644 Documentation/devicetree/bindings/phy/calxeda-combophy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/calxeda-combophy.txt b/Documentation/devicetree/bindings/phy/calxeda-combophy.txt
> deleted file mode 100644
> index 6622bdb2e8bc..000000000000
> --- a/Documentation/devicetree/bindings/phy/calxeda-combophy.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -Calxeda Highbank Combination Phys for SATA
> -
> -Properties:
> -- compatible : Should be "calxeda,hb-combophy"
> -- #phy-cells: Should be 1.
> -- reg : Address and size for Combination Phy registers.
> -- phydev: device ID for programming the combophy.
> -
> -Example:
> -
> -	combophy5: combo-phy@fff5d000 {
> -		compatible = "calxeda,hb-combophy";
> -		#phy-cells = <1>;
> -		reg = <0xfff5d000 0x1000>;
> -		phydev = <31>;
> -	};
> -
> diff --git a/Documentation/devicetree/bindings/phy/calxeda-combophy.yaml b/Documentation/devicetree/bindings/phy/calxeda-combophy.yaml
> new file mode 100644
> index 000000000000..2ef68b95fae1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/calxeda-combophy.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/calxeda-combophy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Calxeda Highbank Combination PHYs binding for SATA
> +
> +description: |
> +  The Calxeda Combination PHYs connect the SoC to the internal fabric
> +  and to SATA connectors. The PHYs support multiple protocols (SATA,
> +  SGMII, PCIe) and can be assigned to different devices (SATA or XGMAC
> +  controller).
> +  Programming the PHYs is typically handled by those device drivers,
> +  not by a dedicated PHY driver.
> +
> +maintainers:
> +  - Andre Przywara <andre.przywara@arm.com>
> +
> +properties:
> +  compatible:
> +    const: calxeda,hb-combophy
> +
> +  '#phy-cells':
> +    const: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +  phydev:
> +    description: device ID for programming the combophy.
> +    $ref: /schemas/types.yaml#/definitions/uint32

I guess you can limit the range here, or does it cover the whole u32
range?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]