From: Kees Cook <keescook@chromium.org>
To: Scott Wood <oss@buserror.net>
Cc: Jason Yan <yanaijie@huawei.com>,
pmladek@suse.com, rostedt@goodmis.org,
sergey.senozhatsky@gmail.com, andriy.shevchenko@linux.intel.com,
linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org,
"Tobin C . Harding" <tobin@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Daniel Axtens <dja@axtens.net>
Subject: Re: [PATCH v3 0/6] implement KASLR for powerpc/fsl_booke/64
Date: Wed, 4 Mar 2020 14:36:59 -0800 [thread overview]
Message-ID: <202003041433.5E2AAC5@keescook> (raw)
In-Reply-To: <b5854fd867982527c107138d52a61010079d2321.camel@buserror.net>
On Wed, Mar 04, 2020 at 03:11:39PM -0600, Scott Wood wrote:
> In any case, this came up now due to a question about what to use when
> printing crash dumps. PowerPC currently prints stack and return addresses
> with %lx (in addition to %pS in the latter case) and someone proposed
Right -- I think other archs moved entirely to %pS and just removed %lx
and %p uses.
> converting them to %p and/or removing them altogether. Is there a consensus
> on whether crash dumps need to be sanitized of this stuff as well? It seems
> like you'd have the addresses in the register dump as well (please don't take
> that away too...). Maybe crash dumps would be a less problematic place to
> make the hashing conditional (i.e. less likely to break something in userspace
> that wasn't expecting a hash)?
Actual _crash_ dumps print all kinds of stuff, even the KASLR offset,
but for generic stack traces, it's been mainly %pS, with things like
registers using %lx.
I defer to Linus, obviously. I just wanted to repeat what he'd said
before.
--
Kees Cook
next prev parent reply other threads:[~2020-03-04 22:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 12:47 [PATCH] vfsprintf: only hash addresses in security environment Jason Yan
2020-03-04 15:12 ` Andy Shevchenko
2020-03-04 18:34 ` Kees Cook
2020-03-04 21:11 ` [PATCH v3 0/6] implement KASLR for powerpc/fsl_booke/64 Scott Wood
2020-03-04 22:36 ` Kees Cook [this message]
2020-03-05 18:51 ` Linus Torvalds
2020-03-06 18:33 ` Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2020-02-06 2:58 Jason Yan
2020-02-13 3:00 ` Jason Yan
2020-02-20 3:33 ` Jason Yan
2020-02-26 7:16 ` Daniel Axtens
2020-02-26 8:18 ` Jason Yan
2020-02-26 11:41 ` Daniel Axtens
2020-02-27 1:55 ` Jason Yan
2020-02-28 5:53 ` Scott Wood
2020-02-28 6:47 ` Jason Yan
2020-02-29 4:28 ` Scott Wood
2020-02-29 7:27 ` Jason Yan
2020-02-29 22:54 ` Scott Wood
2020-03-02 2:17 ` Jason Yan
2020-03-02 3:24 ` Scott Wood
2020-03-02 7:12 ` Jason Yan
2020-03-02 8:47 ` Scott Wood
2020-03-02 9:37 ` Jason Yan
2020-03-04 21:21 ` Scott Wood
2020-03-05 3:22 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003041433.5E2AAC5@keescook \
--to=keescook@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dja@axtens.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=oss@buserror.net \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tobin@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).