From: Jordan Crouse <jcrouse@codeaurora.org>
To: Sharat Masetty <smasetty@codeaurora.org>
Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
dri-devel@freedesktop.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, mka@chromium.org,
sibis@codeaurora.org, saravanak@google.com,
viresh.kumar@linaro.org
Subject: Re: [PATCH 4/5] drm: msm: a6xx: Fix off by one error when setting GPU freq
Date: Tue, 31 Mar 2020 10:43:59 -0600 [thread overview]
Message-ID: <20200331164359.GA11573@jcrouse1-lnx.qualcomm.com> (raw)
In-Reply-To: <1585641353-23229-5-git-send-email-smasetty@codeaurora.org>
On Tue, Mar 31, 2020 at 01:25:52PM +0530, Sharat Masetty wrote:
> This patch fixes an error in the for loop, thereby allowing search on
> the full list of possible GPU power levels.
>
> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
Oh fun. This qualifies for drm-fixes. Can you pull this out of the stack and CC
stable?
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 489d9b6..81b8559 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -176,7 +176,7 @@ void a6xx_gmu_set_freq(struct msm_gpu *gpu, unsigned long freq)
> if (freq == gmu->freq)
> return;
>
> - for (perf_index = 0; perf_index < gmu->nr_gpu_freqs - 1; perf_index++)
> + for (perf_index = 0; perf_index < gmu->nr_gpu_freqs; perf_index++)
> if (freq == gmu->gpu_freqs[perf_index])
> break;
>
> --
> 2.7.4
>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-03-31 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 7:55 [PATCH 0/5] Add support for GPU DDR BW scaling Sharat Masetty
2020-03-31 7:55 ` [PATCH 1/5] arm64: dts: qcom: sc7180: Add interconnect bindings for GPU Sharat Masetty
2020-03-31 7:55 ` [PATCH 2/5] arm64: dts: qcom: sc7180: Add GPU DDR BW opp table Sharat Masetty
2020-03-31 7:55 ` [PATCH 3/5] drm: msm: scale DDR BW along with GPU frequency Sharat Masetty
2020-03-31 17:26 ` Jordan Crouse
2020-04-01 12:30 ` Sharat Masetty
2020-03-31 7:55 ` [PATCH 4/5] drm: msm: a6xx: Fix off by one error when setting GPU freq Sharat Masetty
2020-03-31 16:43 ` Jordan Crouse [this message]
2020-03-31 7:55 ` [PATCH 5/5] dt-bindings: drm/msm/gpu: Document OPP phandle list for the GPU Sharat Masetty
2020-04-10 17:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331164359.GA11573@jcrouse1-lnx.qualcomm.com \
--to=jcrouse@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=saravanak@google.com \
--cc=sibis@codeaurora.org \
--cc=smasetty@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).