* [PATCH] clang-format: don't indent namespaces
@ 2020-04-09 0:13 Ian Rogers
2020-04-18 11:52 ` Miguel Ojeda
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2020-04-09 0:13 UTC (permalink / raw)
To: Miguel Ojeda, linux-kernel, clang-built-linux; +Cc: Ian Rogers
This change doesn't affect existing code. Inner namespace indentation
can lead to a lot of indentation in the case of anonymous namespaces and
the like, impeding readability. Of the clang-format builtin styles
LLVM, Google, Chromium and Mozilla use None while WebKit uses Inner.
Signed-off-by: Ian Rogers <irogers@google.com>
---
.clang-format | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.clang-format b/.clang-format
index 6ec5558b516b..2d7754a4b6d8 100644
--- a/.clang-format
+++ b/.clang-format
@@ -482,7 +482,7 @@ KeepEmptyLinesAtTheStartOfBlocks: false
MacroBlockBegin: ''
MacroBlockEnd: ''
MaxEmptyLinesToKeep: 1
-NamespaceIndentation: Inner
+NamespaceIndentation: None
#ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0
ObjCBlockIndentWidth: 8
ObjCSpaceAfterProperty: true
--
2.26.0.292.g33ef6b2f38-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clang-format: don't indent namespaces
2020-04-09 0:13 [PATCH] clang-format: don't indent namespaces Ian Rogers
@ 2020-04-18 11:52 ` Miguel Ojeda
0 siblings, 0 replies; 2+ messages in thread
From: Miguel Ojeda @ 2020-04-18 11:52 UTC (permalink / raw)
To: Ian Rogers; +Cc: linux-kernel, clang-built-linux
Hi Ian,
On Thu, Apr 9, 2020 at 2:13 AM Ian Rogers <irogers@google.com> wrote:
>
> This change doesn't affect existing code. Inner namespace indentation
> can lead to a lot of indentation in the case of anonymous namespaces and
> the like, impeding readability. Of the clang-format builtin styles
> LLVM, Google, Chromium and Mozilla use None while WebKit uses Inner.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Picking it up for -rc2/3.
Cheers,
Miguel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-18 11:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 0:13 [PATCH] clang-format: don't indent namespaces Ian Rogers
2020-04-18 11:52 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).