* [PATCH v4] arm64: dts: meson: S922X: extend cpu opp-points
@ 2020-04-26 16:21 Tim Lewis
2020-04-27 9:06 ` Jerome Brunet
0 siblings, 1 reply; 4+ messages in thread
From: Tim Lewis @ 2020-04-26 16:21 UTC (permalink / raw)
To: elatllat
Cc: narmstrong, khilman, christianshewitt, joy.cho, tobetter,
linux-amlogic, linux-kernel, linux-arm-kernel, devicetree,
mark.rutland, robh+dt
Add extra cpu pop points to allow mild overclock on S922X. The opp
points are found in Hardkernel N2 sources [1] and testing shows no
obvious issues on other S922X devices. Thermal throttling should
keep things in-check if needed.
[1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
Tested-by: Christian Hewitt <christianshewitt@gmail.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Tim Lewis <elatllat@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
1 files changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
index 046cc332d..1e5d0ee5d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
@@ -65,6 +65,11 @@
opp-hz = /bits/ 64 <1896000000>;
opp-microvolt = <981000>;
};
+
+ opp-1992000000 {
+ opp-hz = /bits/ 64 <1992000000>;
+ opp-microvolt = <1001000>;
+ };
};
cpub_opp_table_1: opp-table-1 {
@@ -120,5 +125,15 @@
opp-hz = /bits/ 64 <1704000000>;
opp-microvolt = <891000>;
};
+
+ opp-1800000000 {
+ opp-hz = /bits/ 64 <1800000000>;
+ opp-microvolt = <981000>;
+ };
+
+ opp-1908000000 {
+ opp-hz = /bits/ 64 <1908000000>;
+ opp-microvolt = <1022000>;
+ };
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4] arm64: dts: meson: S922X: extend cpu opp-points
2020-04-26 16:21 [PATCH v4] arm64: dts: meson: S922X: extend cpu opp-points Tim Lewis
@ 2020-04-27 9:06 ` Jerome Brunet
2020-04-27 9:19 ` Christian Hewitt
0 siblings, 1 reply; 4+ messages in thread
From: Jerome Brunet @ 2020-04-27 9:06 UTC (permalink / raw)
To: elatllat
Cc: mark.rutland, devicetree, joy.cho, narmstrong, khilman,
christianshewitt, linux-kernel, robh+dt, tobetter, linux-amlogic,
linux-arm-kernel
On Sun 26 Apr 2020 at 18:21, Tim Lewis <elatllat@gmail.com> wrote:
> Add extra cpu pop points to allow mild overclock on S922X. The opp
> points are found in Hardkernel N2 sources [1] and testing shows no
> obvious issues on other S922X devices. Thermal throttling should
> keep things in-check if needed.
The Odroid-N2 has a massive heatsink mounted.
Do we have any idea if this applies (is safe) on any other S922x
device ?
It would be nice to get some input (review) from Amlogic is this to
included for any devices using the SoC.
In the meantime, I think this should be applied to odroid-n2 dt only.
>
> [1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Tim Lewis <elatllat@gmail.com>
>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
> 1 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> index 046cc332d..1e5d0ee5d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> @@ -65,6 +65,11 @@
> opp-hz = /bits/ 64 <1896000000>;
> opp-microvolt = <981000>;
> };
> +
> + opp-1992000000 {
> + opp-hz = /bits/ 64 <1992000000>;
> + opp-microvolt = <1001000>;
> + };
> };
>
> cpub_opp_table_1: opp-table-1 {
> @@ -120,5 +125,15 @@
> opp-hz = /bits/ 64 <1704000000>;
> opp-microvolt = <891000>;
> };
> +
> + opp-1800000000 {
> + opp-hz = /bits/ 64 <1800000000>;
> + opp-microvolt = <981000>;
> + };
> +
> + opp-1908000000 {
> + opp-hz = /bits/ 64 <1908000000>;
> + opp-microvolt = <1022000>;
> + };
> };
> };
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] arm64: dts: meson: S922X: extend cpu opp-points
2020-04-27 9:06 ` Jerome Brunet
@ 2020-04-27 9:19 ` Christian Hewitt
2020-04-29 18:54 ` Kevin Hilman
0 siblings, 1 reply; 4+ messages in thread
From: Christian Hewitt @ 2020-04-27 9:19 UTC (permalink / raw)
To: Jerome Brunet
Cc: Tim Lewis, mark.rutland, devicetree, joy.cho, narmstrong,
khilman, linux-kernel, robh+dt, tobetter, linux-amlogic,
linux-arm-kernel
> On 27 Apr 2020, at 1:06 pm, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> On Sun 26 Apr 2020 at 18:21, Tim Lewis <elatllat@gmail.com> wrote:
>
>> Add extra cpu pop points to allow mild overclock on S922X. The opp
>> points are found in Hardkernel N2 sources [1] and testing shows no
>> obvious issues on other S922X devices. Thermal throttling should
>> keep things in-check if needed.
>
> The Odroid-N2 has a massive heatsink mounted.
> Do we have any idea if this applies (is safe) on any other S922x
> device ?
I’ve tested it on several S922X box devices that I have, and also the
original S922X version of the VIM3 - all have similar sized passive
heatsinks about 20% the size of the N2 one. No obvious issues with
Kodi software decoding to increase CPU usage. NB: The original patch
submission was N2 specific and then reworked to apply to all S922X
devices at Neil’s suggestion (after my TB and earlier comments).
CH.
[snip]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] arm64: dts: meson: S922X: extend cpu opp-points
2020-04-27 9:19 ` Christian Hewitt
@ 2020-04-29 18:54 ` Kevin Hilman
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2020-04-29 18:54 UTC (permalink / raw)
To: Christian Hewitt, Jerome Brunet
Cc: Tim Lewis, mark.rutland, devicetree, joy.cho, narmstrong,
linux-kernel, robh+dt, tobetter, linux-amlogic, linux-arm-kernel
Christian Hewitt <christianshewitt@gmail.com> writes:
>> On 27 Apr 2020, at 1:06 pm, Jerome Brunet <jbrunet@baylibre.com> wrote:
>>
>> On Sun 26 Apr 2020 at 18:21, Tim Lewis <elatllat@gmail.com> wrote:
>>
>>> Add extra cpu pop points to allow mild overclock on S922X. The opp
>>> points are found in Hardkernel N2 sources [1] and testing shows no
>>> obvious issues on other S922X devices. Thermal throttling should
>>> keep things in-check if needed.
>>
>> The Odroid-N2 has a massive heatsink mounted.
>> Do we have any idea if this applies (is safe) on any other S922x
>> device ?
>
> I’ve tested it on several S922X box devices that I have, and also the
> original S922X version of the VIM3 - all have similar sized passive
> heatsinks about 20% the size of the N2 one. No obvious issues with
> Kodi software decoding to increase CPU usage. NB: The original patch
> submission was N2 specific and then reworked to apply to all S922X
> devices at Neil’s suggestion (after my TB and earlier comments).
Yes, we also have OPP lowering enabled by default (which I think Neil
mentioned earlier) so this should be safe (enough) to apply.
Queuing for v5.8,
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-29 18:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 16:21 [PATCH v4] arm64: dts: meson: S922X: extend cpu opp-points Tim Lewis
2020-04-27 9:06 ` Jerome Brunet
2020-04-27 9:19 ` Christian Hewitt
2020-04-29 18:54 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).