linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpu: host1x: Clean up debugfs in error handling path in 'host1x_probe()'
@ 2020-04-26 19:16 Christophe JAILLET
  2020-05-08 10:26 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2020-04-26 19:16 UTC (permalink / raw)
  To: thierry.reding
  Cc: dri-devel, linux-tegra, linux-kernel, kernel-janitors,
	Christophe JAILLET

'host1x_debug_init()' must be reverted in an error handling path.

This is already fixed in the remove function since commit 44156eee91ba
("gpu: host1x: Clean up debugfs on removal")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/host1x/dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
index 388bcc2889aa..be46554968af 100644
--- a/drivers/gpu/host1x/dev.c
+++ b/drivers/gpu/host1x/dev.c
@@ -435,6 +435,7 @@ static int host1x_probe(struct platform_device *pdev)
 	return 0;
 
 deinit_intr:
+	host1x_debug_deinit(host);
 	host1x_intr_deinit(host);
 deinit_syncpt:
 	host1x_syncpt_deinit(host);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpu: host1x: Clean up debugfs in error handling path in 'host1x_probe()'
  2020-04-26 19:16 [PATCH] gpu: host1x: Clean up debugfs in error handling path in 'host1x_probe()' Christophe JAILLET
@ 2020-05-08 10:26 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2020-05-08 10:26 UTC (permalink / raw)
  To: Christophe JAILLET; +Cc: dri-devel, linux-tegra, linux-kernel, kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Sun, Apr 26, 2020 at 09:16:30PM +0200, Christophe JAILLET wrote:
> 'host1x_debug_init()' must be reverted in an error handling path.
> 
> This is already fixed in the remove function since commit 44156eee91ba
> ("gpu: host1x: Clean up debugfs on removal")
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/host1x/dev.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-08 10:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 19:16 [PATCH] gpu: host1x: Clean up debugfs in error handling path in 'host1x_probe()' Christophe JAILLET
2020-05-08 10:26 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).