[PATCH net 1/1] net: ipa: don't be a hog in gsi_channel_poll()

[PATCH net 1/1] net: ipa: don't be a hog in gsi_channel_poll()

[Alex Elder]

The iteration count value used in gsi_channel_poll() is intended to
limit poll iterations to the budget supplied as an argument.  But
it's never updated.

Fix this bug by incrementing the count each time through the loop.

Reported-by: Sharath Chandra Vurukala <sharathv@codeaurora.com>
Signed-off-by: Alex Elder <elder@linaro.org>
---
 drivers/net/ipa/gsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index b671bea0aa7c..8d9ca1c335e8 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -1392,6 +1392,7 @@ static int gsi_channel_poll(struct napi_struct *napi, int budget)
 	while (count < budget) {
 		struct gsi_trans *trans;
 
+		count++;
 		trans = gsi_channel_poll_one(channel);
 		if (!trans)
 			break;
-- 
2.20.1

Re: [PATCH net 1/1] net: ipa: don't be a hog in gsi_channel_poll()

[David Miller]

From: Alex Elder <elder@linaro.org>
Date: Fri, 15 May 2020 14:52:03 -0500

> The iteration count value used in gsi_channel_poll() is intended to
> limit poll iterations to the budget supplied as an argument.  But
> it's never updated.
> 
> Fix this bug by incrementing the count each time through the loop.
> 
> Reported-by: Sharath Chandra Vurukala <sharathv@codeaurora.com>
> Signed-off-by: Alex Elder <elder@linaro.org>

Applied, thanks.