* [PATCH] RDMA/core: fix missing release in add_port.
@ 2020-05-25 6:06 wu000273
2020-05-25 13:03 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: wu000273 @ 2020-05-25 6:06 UTC (permalink / raw)
To: dledford; +Cc: jgg, leon, linux-rdma, linux-kernel, kjlu, wu000273
From: Qiushi Wu <wu000273@umn.edu>
In function add_port(), pointer p is not released in error paths.
Fix this issue by adding a kfree(p) into the end of error path.
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
drivers/infiniband/core/sysfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 087682e6969e..04a003378dfc 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -1202,6 +1202,7 @@ static int add_port(struct ib_core_device *coredev, int port_num)
err_put:
kobject_put(&p->kobj);
+ kfree(p);
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] RDMA/core: fix missing release in add_port.
2020-05-25 6:06 [PATCH] RDMA/core: fix missing release in add_port wu000273
@ 2020-05-25 13:03 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-05-25 13:03 UTC (permalink / raw)
To: wu000273; +Cc: dledford, leon, linux-rdma, linux-kernel, kjlu
On Mon, May 25, 2020 at 01:06:56AM -0500, wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>
> In function add_port(), pointer p is not released in error paths.
> Fix this issue by adding a kfree(p) into the end of error path.
>
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
> drivers/infiniband/core/sysfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 087682e6969e..04a003378dfc 100644
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -1202,6 +1202,7 @@ static int add_port(struct ib_core_device *coredev, int port_num)
>
> err_put:
> kobject_put(&p->kobj);
> + kfree(p);
> return ret;
> }
Er, no, kobject_put does the kfree
There is a bug here, it is calling kfree() after kobject_init_and_add
fails, which is wrong, it should be goto err_put
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-25 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25 6:06 [PATCH] RDMA/core: fix missing release in add_port wu000273
2020-05-25 13:03 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).