[RFT PATCH] ia64: Fix build error with !COREDUMP

[RFT PATCH] ia64: Fix build error with !COREDUMP

[Krzysztof Kozlowski]

Fix linkage error when CONFIG_BINFMT_ELF is selected but CONFIG_COREDUMP
is not:

    ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function `elf_core_write_extra_phdrs':
    elfcore.c:(.text+0x172): undefined reference to `dump_emit'
    ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function `elf_core_write_extra_data':
    elfcore.c:(.text+0x2b2): undefined reference to `dump_emit'

Cc: <stable@vger.kernel.org>
Fixes: 1fcccbac89f5 ("elf coredump: replace ELF_CORE_EXTRA_* macros by functions")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Please let kbuild test it for a while before applying. I built it only
on few configurations.

This is similar fix to commit 42d91f612c87 ("um: Fix build error and
kconfig for i386") although I put different fixes tag - the commit which
introduced this part of code.
---
 arch/ia64/kernel/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/ia64/kernel/Makefile b/arch/ia64/kernel/Makefile
index 1a8df6669eee..18d6008b151f 100644
--- a/arch/ia64/kernel/Makefile
+++ b/arch/ia64/kernel/Makefile
@@ -41,7 +41,7 @@ obj-y				+= esi_stub.o	# must be in kernel proper
 endif
 obj-$(CONFIG_INTEL_IOMMU)	+= pci-dma.o
 
-obj-$(CONFIG_BINFMT_ELF)	+= elfcore.o
+obj-$(CONFIG_ELF_CORE)		+= elfcore.o
 
 # fp_emulate() expects f2-f5,f16-f31 to contain the user-level state.
 CFLAGS_traps.o  += -mfixed-range=f2-f5,f16-f31
-- 
2.17.1

Re: [RFT PATCH] ia64: Fix build error with !COREDUMP

[Krzysztof Kozlowski]

On Thu, Jun 04, 2020 at 10:18:42PM +0200, Krzysztof Kozlowski wrote:
> Fix linkage error when CONFIG_BINFMT_ELF is selected but CONFIG_COREDUMP
> is not:
> 
>     ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function `elf_core_write_extra_phdrs':
>     elfcore.c:(.text+0x172): undefined reference to `dump_emit'
>     ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function `elf_core_write_extra_data':
>     elfcore.c:(.text+0x2b2): undefined reference to `dump_emit'
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 1fcccbac89f5 ("elf coredump: replace ELF_CORE_EXTRA_* macros by functions")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Please let kbuild test it for a while before applying. I built it only
> on few configurations.
> 
> This is similar fix to commit 42d91f612c87 ("um: Fix build error and
> kconfig for i386") although I put different fixes tag - the commit which
> introduced this part of code.

Kernel-test-robot did not complain anymore so I think build tests
passed.

Any comments here?

Best regards,
Krzysztof