linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Remove unneeded variable t1
@ 2020-08-18  8:05 Xu Wang
  2020-08-28  6:57 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2020-08-18  8:05 UTC (permalink / raw)
  To: herbert, davem, linux-crypto; +Cc: linux-kernel, Xu Wang

Remove unneeded variable t1 seed_encrypt() and
seed_decrypt().

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 crypto/seed.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/seed.c b/crypto/seed.c
index 5e3bef3a617d..69b3058d6a32 100644
--- a/crypto/seed.c
+++ b/crypto/seed.c
@@ -366,7 +366,7 @@ static void seed_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
 	const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
 	const __be32 *src = (const __be32 *)in;
 	__be32 *dst = (__be32 *)out;
-	u32 x1, x2, x3, x4, t0, t1;
+	u32 x1, x2, x3, x4, t0;
 	const u32 *ks = ctx->keysched;
 
 	x1 = be32_to_cpu(src[0]);
@@ -404,7 +404,7 @@ static void seed_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
 	const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
 	const __be32 *src = (const __be32 *)in;
 	__be32 *dst = (__be32 *)out;
-	u32 x1, x2, x3, x4, t0, t1;
+	u32 x1, x2, x3, x4, t0;
 	const u32 *ks = ctx->keysched;
 
 	x1 = be32_to_cpu(src[0]);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove unneeded variable t1
  2020-08-18  8:05 [PATCH] Remove unneeded variable t1 Xu Wang
@ 2020-08-28  6:57 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-08-28  6:57 UTC (permalink / raw)
  To: Xu Wang; +Cc: davem, linux-crypto, linux-kernel, vulab

Xu Wang <vulab@iscas.ac.cn> wrote:
> Remove unneeded variable t1 seed_encrypt() and
> seed_decrypt().
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> crypto/seed.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/crypto/seed.c b/crypto/seed.c
> index 5e3bef3a617d..69b3058d6a32 100644
> --- a/crypto/seed.c
> +++ b/crypto/seed.c
> @@ -366,7 +366,7 @@ static void seed_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
>        const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
>        const __be32 *src = (const __be32 *)in;
>        __be32 *dst = (__be32 *)out;
> -       u32 x1, x2, x3, x4, t0, t1;
> +       u32 x1, x2, x3, x4, t0;
>        const u32 *ks = ctx->keysched;
> 
>        x1 = be32_to_cpu(src[0]);
> @@ -404,7 +404,7 @@ static void seed_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
>        const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
>        const __be32 *src = (const __be32 *)in;
>        __be32 *dst = (__be32 *)out;
> -       u32 x1, x2, x3, x4, t0, t1;
> +       u32 x1, x2, x3, x4, t0;
>        const u32 *ks = ctx->keysched;
> 
>        x1 = be32_to_cpu(src[0]);

This doesn't even compile!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-28  6:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18  8:05 [PATCH] Remove unneeded variable t1 Xu Wang
2020-08-28  6:57 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).