* [PATCH] drm/bridge: Fix the dsi remote end-points
@ 2020-08-28 7:42 Vinod Koul
2020-08-29 21:04 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2020-08-28 7:42 UTC (permalink / raw)
To: Sam Ravnborg
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Andrzej Hajda,
Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
David Airlie, Daniel Vetter, Srinivas Kandagatla, dri-devel,
linux-kernel, Dmitry Baryshkov
DSI end-points are supposed to be at node 0 and node 1 as per binding.
So fix this and use node 0 and node 1 for dsi.
Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index 1009fc4ed4ed..d734d9402c35 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -960,13 +960,13 @@ static const struct drm_bridge_funcs lt9611_bridge_funcs = {
static int lt9611_parse_dt(struct device *dev,
struct lt9611 *lt9611)
{
- lt9611->dsi0_node = of_graph_get_remote_node(dev->of_node, 1, -1);
+ lt9611->dsi0_node = of_graph_get_remote_node(dev->of_node, 0, -1);
if (!lt9611->dsi0_node) {
dev_err(lt9611->dev, "failed to get remote node for primary dsi\n");
return -ENODEV;
}
- lt9611->dsi1_node = of_graph_get_remote_node(dev->of_node, 2, -1);
+ lt9611->dsi1_node = of_graph_get_remote_node(dev->of_node, 1, -1);
lt9611->ac_mode = of_property_read_bool(dev->of_node, "lt,ac-mode");
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: Fix the dsi remote end-points
2020-08-28 7:42 [PATCH] drm/bridge: Fix the dsi remote end-points Vinod Koul
@ 2020-08-29 21:04 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-08-29 21:04 UTC (permalink / raw)
To: Vinod Koul
Cc: linux-arm-msm, Bjorn Andersson, Andrzej Hajda, Neil Armstrong,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Srinivas Kandagatla, dri-devel, linux-kernel,
Dmitry Baryshkov
On Fri, Aug 28, 2020 at 01:12:50PM +0530, Vinod Koul wrote:
> DSI end-points are supposed to be at node 0 and node 1 as per binding.
> So fix this and use node 0 and node 1 for dsi.
>
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Thanks, applied to drm-misc-next.
Sam
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index 1009fc4ed4ed..d734d9402c35 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -960,13 +960,13 @@ static const struct drm_bridge_funcs lt9611_bridge_funcs = {
> static int lt9611_parse_dt(struct device *dev,
> struct lt9611 *lt9611)
> {
> - lt9611->dsi0_node = of_graph_get_remote_node(dev->of_node, 1, -1);
> + lt9611->dsi0_node = of_graph_get_remote_node(dev->of_node, 0, -1);
> if (!lt9611->dsi0_node) {
> dev_err(lt9611->dev, "failed to get remote node for primary dsi\n");
> return -ENODEV;
> }
>
> - lt9611->dsi1_node = of_graph_get_remote_node(dev->of_node, 2, -1);
> + lt9611->dsi1_node = of_graph_get_remote_node(dev->of_node, 1, -1);
>
> lt9611->ac_mode = of_property_read_bool(dev->of_node, "lt,ac-mode");
>
> --
> 2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-29 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 7:42 [PATCH] drm/bridge: Fix the dsi remote end-points Vinod Koul
2020-08-29 21:04 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).