* [PATCH] sched: Fix some comments
@ 2020-09-05 9:27 Miaohe Lin
0 siblings, 0 replies; 2+ messages in thread
From: Miaohe Lin @ 2020-09-05 9:27 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman
Cc: linux-kernel, linmiaohe
Since commit dfa50b605c2a ("sched: Make finish_task_switch() return 'struct
rq *'"), prev == current is incorrect in finish_task_switch(). Also fix a
typo in the comment of struct dl_bandwidth.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
kernel/sched/core.c | 4 ++--
kernel/sched/sched.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 8471a0f7eb32..725ccab230da 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3571,8 +3571,8 @@ prepare_task_switch(struct rq *rq, struct task_struct *prev,
*
* The context switch have flipped the stack from under us and restored the
* local variables which were saved when this task called schedule() in the
- * past. prev == current is still correct but we need to recalculate this_rq
- * because prev may have moved to another CPU.
+ * past. We need to recalculate this_rq because prev may have moved to
+ * another CPU.
*/
static struct rq *finish_task_switch(struct task_struct *prev)
__releases(rq->lock)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 28709f6b0975..1d7e45f7fbb9 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -278,7 +278,7 @@ void __dl_clear_params(struct task_struct *p);
* consume bandwidth on the CPU they're running on.
* Finally, dl_total_bw_cpu is used to cache the index of dl_total_bw
* that will be shown the next time the proc or cgroup controls will
- * be red. It on its turn can be changed by writing on its own
+ * be read. It on its turn can be changed by writing on its own
* control.
*/
struct dl_bandwidth {
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sched: Fix some comments
@ 2020-09-24 13:04 linmiaohe
0 siblings, 0 replies; 2+ messages in thread
From: linmiaohe @ 2020-09-24 13:04 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman
Cc: linux-kernel
Friendly ping. :)
> Since commit dfa50b605c2a ("sched: Make finish_task_switch() return 'struct rq *'"), prev == current is incorrect in finish_task_switch(). Also fix a typo in the comment of struct dl_bandwidth.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> kernel/sched/core.c | 4 ++--
> kernel/sched/sched.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 8471a0f7eb32..725ccab230da 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3571,8 +3571,8 @@ prepare_task_switch(struct rq *rq, struct task_struct *prev,
> *
> * The context switch have flipped the stack from under us and restored the
> * local variables which were saved when this task called schedule() in the
> - * past. prev == current is still correct but we need to recalculate this_rq
> - * because prev may have moved to another CPU.
> + * past. We need to recalculate this_rq because prev may have moved to
> + * another CPU.
> */
> static struct rq *finish_task_switch(struct task_struct *prev)
> __releases(rq->lock)
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 28709f6b0975..1d7e45f7fbb9 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -278,7 +278,7 @@ void __dl_clear_params(struct task_struct *p);
> * consume bandwidth on the CPU they're running on.
> * Finally, dl_total_bw_cpu is used to cache the index of dl_total_bw
> * that will be shown the next time the proc or cgroup controls will
> - * be red. It on its turn can be changed by writing on its own
> + * be read. It on its turn can be changed by writing on its own
> * control.
> */
> struct dl_bandwidth {
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-24 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-05 9:27 [PATCH] sched: Fix some comments Miaohe Lin
2020-09-24 13:04 linmiaohe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).