* [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3
@ 2020-09-13 21:08 Drew Fustini
2020-09-29 12:51 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Drew Fustini @ 2020-09-13 21:08 UTC (permalink / raw)
To: linux-arm-kernel, Tony Lindgren, Rob Herring, linux-omap,
linux-kernel, linux-gpio, Linus Walleij, Haojian Zhuang,
devicetree, bcousson, Jason Kridner, Robert Nelson, Trent Piepho
Cc: Drew Fustini
The property #pinctrl-cells can either be 2 or 3. There is currently
only a check to make sure that #pinctrl-cells is 2 or greater. This
patch adds a check to make sure it is not greater than 3.
Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
Reported-by: Trent Piepho <tpiepho@gmail.com>
Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index efe41abc5d47..5cbf0e55087c 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1014,7 +1014,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
if (res)
return res;
- if (pinctrl_spec.args_count < 2) {
+ if (pinctrl_spec.args_count < 2 || pinctrl_spec.args_count > 3) {
dev_err(pcs->dev, "invalid args_count for spec: %i\n",
pinctrl_spec.args_count);
break;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3
2020-09-13 21:08 [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3 Drew Fustini
@ 2020-09-29 12:51 ` Linus Walleij
2020-09-30 5:16 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2020-09-29 12:51 UTC (permalink / raw)
To: Drew Fustini, Tony Lindgren
Cc: Linux ARM, Rob Herring, Linux-OMAP, linux-kernel,
open list:GPIO SUBSYSTEM, Haojian Zhuang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Benoît Cousson, Jason Kridner, Robert Nelson, Trent Piepho
On Sun, Sep 13, 2020 at 11:17 PM Drew Fustini <drew@beagleboard.org> wrote:
> The property #pinctrl-cells can either be 2 or 3. There is currently
> only a check to make sure that #pinctrl-cells is 2 or greater. This
> patch adds a check to make sure it is not greater than 3.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <tpiepho@gmail.com>
> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
Tony, does this and the other patch look good to you?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3
2020-09-29 12:51 ` Linus Walleij
@ 2020-09-30 5:16 ` Tony Lindgren
2020-09-30 17:53 ` Drew Fustini
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2020-09-30 5:16 UTC (permalink / raw)
To: Linus Walleij
Cc: Drew Fustini, Linux ARM, Rob Herring, Linux-OMAP, linux-kernel,
open list:GPIO SUBSYSTEM, Haojian Zhuang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Benoît Cousson, Jason Kridner, Robert Nelson, Trent Piepho
* Linus Walleij <linus.walleij@linaro.org> [200929 12:51]:
> On Sun, Sep 13, 2020 at 11:17 PM Drew Fustini <drew@beagleboard.org> wrote:
>
> > The property #pinctrl-cells can either be 2 or 3. There is currently
> > only a check to make sure that #pinctrl-cells is 2 or greater. This
> > patch adds a check to make sure it is not greater than 3.
> >
> > Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> > Reported-by: Trent Piepho <tpiepho@gmail.com>
> > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> > Signed-off-by: Drew Fustini <drew@beagleboard.org>
>
> Tony, does this and the other patch look good to you?
Hmm well the description looks a bit confusing, #pinctrl-cells can
also be 1 that's the default. Might be worth clarifying that part.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3
2020-09-30 5:16 ` Tony Lindgren
@ 2020-09-30 17:53 ` Drew Fustini
0 siblings, 0 replies; 4+ messages in thread
From: Drew Fustini @ 2020-09-30 17:53 UTC (permalink / raw)
To: Tony Lindgren
Cc: Linus Walleij, Linux ARM, Rob Herring, Linux-OMAP, linux-kernel,
open list:GPIO SUBSYSTEM, Haojian Zhuang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Benoît Cousson, Jason Kridner, Robert Nelson, Trent Piepho
On Wed, Sep 30, 2020 at 08:16:59AM +0300, Tony Lindgren wrote:
> * Linus Walleij <linus.walleij@linaro.org> [200929 12:51]:
> > On Sun, Sep 13, 2020 at 11:17 PM Drew Fustini <drew@beagleboard.org> wrote:
> >
> > > The property #pinctrl-cells can either be 2 or 3. There is currently
> > > only a check to make sure that #pinctrl-cells is 2 or greater. This
> > > patch adds a check to make sure it is not greater than 3.
> > >
> > > Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> > > Reported-by: Trent Piepho <tpiepho@gmail.com>
> > > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> > > Signed-off-by: Drew Fustini <drew@beagleboard.org>
> >
> > Tony, does this and the other patch look good to you?
>
> Hmm well the description looks a bit confusing, #pinctrl-cells can
> also be 1 that's the default. Might be worth clarifying that part.
>
> Regards,
>
> Tony
Yes, that was my fault for confusing #pinctrl-cells with
pinctrl_spec.args_count.
- if #pinctrl-cells = <1>, then pinctrl_spec.args_count = 2
- if #pinctrl-cells = <2>, then pinctrl_spec.args_count = 3
- all other values are not valid
I will post a v2.
Thanks,
Drew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-30 17:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-13 21:08 [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3 Drew Fustini
2020-09-29 12:51 ` Linus Walleij
2020-09-30 5:16 ` Tony Lindgren
2020-09-30 17:53 ` Drew Fustini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).