Re: [net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio

From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Rob Herring <robh+dt@kernel.org>, davem@davemloft.net
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Grant Likely <grant.likely@arm.com>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Madalin Bucur <madalin.bucur@oss.nxp.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Diana Madalina Craciun <diana.craciun@nxp.com>,
	netdev <netdev@vger.kernel.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"open list:ACPI FOR ARM64 (ACPI/arm64)"
	<linux-acpi@vger.kernel.org>,
	linux.cj@gmail.com, "David S. Miller" <davem@davemloft.net>,
	Frank Rowand <frowand.list@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio
Date: Fri, 9 Oct 2020 07:50:56 +0530	[thread overview]
Message-ID: <20201009022056.GA17999@lsv03152.swis.in-blr01.nxp.com> (raw)
In-Reply-To: <CAL_JsqLf0UJNmx8OgpDye2zfFNZyJJ8gbr3nbmGyiMg81RoHOg@mail.gmail.com>

Hi Rob,

On Thu, Oct 08, 2020 at 11:35:07AM -0500, Rob Herring wrote:
> On Thu, Oct 8, 2020 at 9:47 AM Calvin Johnson
> <calvin.johnson@oss.nxp.com> wrote:
> >
> > Better place for of_mdio.c is drivers/net/mdio.
> > Move of_mdio.c from drivers/of to drivers/net/mdio
> 
> One thing off my todo list. I'd started this ages ago[1].
> 
> >
> > Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
> > ---
> >
> >  MAINTAINERS                        | 2 +-
> >  drivers/net/mdio/Kconfig           | 8 ++++++++
> >  drivers/net/mdio/Makefile          | 2 ++
> >  drivers/{of => net/mdio}/of_mdio.c | 0
> >  drivers/of/Kconfig                 | 7 -------
> >  drivers/of/Makefile                | 1 -
> >  6 files changed, 11 insertions(+), 9 deletions(-)
> >  rename drivers/{of => net/mdio}/of_mdio.c (100%)
> 
> of_mdio.c is really a combination of mdio and phylib functions, so it
> should be split up IMO. With that, I think you can get rid of
> CONFIG_OF_MDIO. See my branch[1] for what I had in mind. But that can
> be done after this if the net maintainers prefer.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 
> Rob
> 
> [1] git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dt/move-net

Makes sense to me to split of_mdio.c. I can work on it once my current task
completes.

Regards
Calvin