From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
davem@davemloft.net, Grant Likely <grant.likely@arm.com>,
Jeremy Linton <jeremy.linton@arm.com>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Diana Madalina Craciun <diana.craciun@nxp.com>,
netdev <netdev@vger.kernel.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ACPI FOR ARM64 (ACPI/arm64)"
<linux-acpi@vger.kernel.org>,
linux.cj@gmail.com, Frank Rowand <frowand.list@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio
Date: Fri, 9 Oct 2020 12:36:36 +0530 [thread overview]
Message-ID: <20201009070636.GA31495@lsv03152.swis.in-blr01.nxp.com> (raw)
In-Reply-To: <2a0f9055-9110-ecc5-aab2-ff6ec9dc157a@gmail.com>
Hi Florian,
On Thu, Oct 08, 2020 at 07:26:44PM -0700, Florian Fainelli wrote:
>
>
> On 10/8/2020 7:20 PM, Calvin Johnson wrote:
> > Hi Rob,
> >
> > On Thu, Oct 08, 2020 at 11:35:07AM -0500, Rob Herring wrote:
> > > On Thu, Oct 8, 2020 at 9:47 AM Calvin Johnson
> > > <calvin.johnson@oss.nxp.com> wrote:
> > > >
> > > > Better place for of_mdio.c is drivers/net/mdio.
> > > > Move of_mdio.c from drivers/of to drivers/net/mdio
> > >
> > > One thing off my todo list. I'd started this ages ago[1].
> > >
> > > >
> > > > Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
> > > > ---
> > > >
> > > > MAINTAINERS | 2 +-
> > > > drivers/net/mdio/Kconfig | 8 ++++++++
> > > > drivers/net/mdio/Makefile | 2 ++
> > > > drivers/{of => net/mdio}/of_mdio.c | 0
> > > > drivers/of/Kconfig | 7 -------
> > > > drivers/of/Makefile | 1 -
> > > > 6 files changed, 11 insertions(+), 9 deletions(-)
> > > > rename drivers/{of => net/mdio}/of_mdio.c (100%)
> > >
> > > of_mdio.c is really a combination of mdio and phylib functions, so it
> > > should be split up IMO. With that, I think you can get rid of
> > > CONFIG_OF_MDIO. See my branch[1] for what I had in mind. But that can
> > > be done after this if the net maintainers prefer.
> > >
> > > Acked-by: Rob Herring <robh@kernel.org>
> > >
> > > Rob
> > >
> > > [1] git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dt/move-net
> >
> > Makes sense to me to split of_mdio.c. I can work on it once my current task
> > completes.
>
> If you could take Rob's patches, given then a round of randconfig build
> tests and update the MAINTAINERS file (no more drivers/of/of_mdio.c), then
> this looks like the right approach to me. Thanks!
I gave a quick try with those patches and it needs some more work to apply
as they are bit old. I can look into this later afer the ACPI work is done.
For now, this patch is good to merge as I've done some sanity.
Thanks
Calvin
next prev parent reply other threads:[~2020-10-09 7:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 14:47 [net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio Calvin Johnson
2020-10-08 15:14 ` Grant Likely
2020-10-08 16:35 ` Rob Herring
2020-10-09 2:20 ` Calvin Johnson
2020-10-09 2:26 ` Florian Fainelli
2020-10-09 7:06 ` Calvin Johnson [this message]
2020-10-10 17:57 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009070636.GA31495@lsv03152.swis.in-blr01.nxp.com \
--to=calvin.johnson@oss.nxp.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=frowand.list@gmail.com \
--cc=grant.likely@arm.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=kuba@kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=mchehab+huawei@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).