* sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
@ 2020-10-19 1:41 kernel test robot
2020-10-19 14:36 ` Pierre-Louis Bossart
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2020-10-19 1:41 UTC (permalink / raw)
To: Daniel Baluta
Cc: kbuild-all, linux-kernel, Mark Brown, Ranjani Sridharan,
Pierre-Louis Bossart
[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7cf726a59435301046250c42131554d9ccc566b8
commit: 285880a23d105e5d34b311b0c44061dffb07e405 ASoC: SOF: Make creation of machine device from SOF core optional
date: 10 months ago
config: i386-randconfig-m021-20201019 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
sound/soc/sof/sof-audio.c:380 sof_machine_check() warn: ignoring unreachable code.
vim +375 sound/soc/sof/sof-audio.c
362
363 /*
364 * SOF Driver enumeration.
365 */
366 int sof_machine_check(struct snd_sof_dev *sdev)
367 {
368 struct snd_sof_pdata *sof_pdata = sdev->pdata;
369 const struct sof_dev_desc *desc = sof_pdata->desc;
370 struct snd_soc_acpi_mach *mach;
371 int ret;
372
373 /* force nocodec mode */
374 #if IS_ENABLED(CONFIG_SND_SOC_SOF_FORCE_NOCODEC_MODE)
> 375 dev_warn(sdev->dev, "Force to use nocodec mode\n");
376 goto nocodec;
377 #endif
378
379 /* find machine */
> 380 snd_sof_machine_select(sdev);
381 if (sof_pdata->machine) {
382 snd_sof_set_mach_params(sof_pdata->machine, sdev->dev);
383 return 0;
384 }
385
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29062 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
2020-10-19 1:41 sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting kernel test robot
@ 2020-10-19 14:36 ` Pierre-Louis Bossart
0 siblings, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2020-10-19 14:36 UTC (permalink / raw)
To: kernel test robot, Daniel Baluta
Cc: kbuild-all, linux-kernel, Mark Brown, Ranjani Sridharan, Kai Vehmanen
On 10/18/20 8:41 PM, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 7cf726a59435301046250c42131554d9ccc566b8
> commit: 285880a23d105e5d34b311b0c44061dffb07e405 ASoC: SOF: Make creation of machine device from SOF core optional
> date: 10 months ago
> config: i386-randconfig-m021-20201019 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> smatch warnings:
> sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
> sound/soc/sof/sof-audio.c:380 sof_machine_check() warn: ignoring unreachable code.
we provided a fix for this:
[PATCH 3/4] ASoC: SOF: sof-audio: remove goto used for force-nocodec support
but I don't see it in Mark's tree. That was part of the series
"[PATCH 0/4] ASoC: SOF: cleanups for 5.10" shared by Kai Vehmanen on
September 30.
I don't recall what happened with this series?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
2020-09-18 1:50 kernel test robot
@ 2020-09-18 16:34 ` Pierre-Louis Bossart
0 siblings, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2020-09-18 16:34 UTC (permalink / raw)
To: kernel test robot, Daniel Baluta
Cc: kbuild-all, linux-kernel, Mark Brown, Ranjani Sridharan
On 9/17/20 8:50 PM, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 4cbffc461ec91287c4cb1d0e27b01b988d0b8fba
> commit: 285880a23d105e5d34b311b0c44061dffb07e405 ASoC: SOF: Make creation of machine device from SOF core optional
> date: 9 months ago
> config: s390-randconfig-m031-20200917 (attached as .config)
> compiler: s390-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> smatch warnings:
> sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
> sound/soc/sof/sof-audio.c:380 sof_machine_check() warn: ignoring unreachable code.
Ack, fix is on its way. Thanks for the report.
^ permalink raw reply [flat|nested] 4+ messages in thread
* sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
@ 2020-09-18 1:50 kernel test robot
2020-09-18 16:34 ` Pierre-Louis Bossart
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2020-09-18 1:50 UTC (permalink / raw)
To: Daniel Baluta
Cc: kbuild-all, linux-kernel, Mark Brown, Ranjani Sridharan,
Pierre-Louis Bossart
[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4cbffc461ec91287c4cb1d0e27b01b988d0b8fba
commit: 285880a23d105e5d34b311b0c44061dffb07e405 ASoC: SOF: Make creation of machine device from SOF core optional
date: 9 months ago
config: s390-randconfig-m031-20200917 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting
sound/soc/sof/sof-audio.c:380 sof_machine_check() warn: ignoring unreachable code.
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=285880a23d105e5d34b311b0c44061dffb07e405
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 285880a23d105e5d34b311b0c44061dffb07e405
vim +375 sound/soc/sof/sof-audio.c
362
363 /*
364 * SOF Driver enumeration.
365 */
366 int sof_machine_check(struct snd_sof_dev *sdev)
367 {
368 struct snd_sof_pdata *sof_pdata = sdev->pdata;
369 const struct sof_dev_desc *desc = sof_pdata->desc;
370 struct snd_soc_acpi_mach *mach;
371 int ret;
372
373 /* force nocodec mode */
374 #if IS_ENABLED(CONFIG_SND_SOC_SOF_FORCE_NOCODEC_MODE)
> 375 dev_warn(sdev->dev, "Force to use nocodec mode\n");
376 goto nocodec;
377 #endif
378
379 /* find machine */
> 380 snd_sof_machine_select(sdev);
381 if (sof_pdata->machine) {
382 snd_sof_set_mach_params(sof_pdata->machine, sdev->dev);
383 return 0;
384 }
385
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26922 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-19 14:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 1:41 sound/soc/sof/sof-audio.c:375 sof_machine_check() warn: inconsistent indenting kernel test robot
2020-10-19 14:36 ` Pierre-Louis Bossart
-- strict thread matches above, loose matches on Subject: below --
2020-09-18 1:50 kernel test robot
2020-09-18 16:34 ` Pierre-Louis Bossart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).