From: Aditya Srivastava <yashsri421@gmail.com>
To: joe@perches.com
Cc: yashsri421@gmail.com, lukas.bulwahn@gmail.com,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH] checkpatch: add fix for non-standard signature - co-authored-by
Date: Wed, 2 Dec 2020 14:38:28 +0530 [thread overview]
Message-ID: <20201202090828.12934-1-yashsri421@gmail.com> (raw)
In-Reply-To: <ceb3ffcdae151d6ea1d7f1a45bf61b3d2a1c183c.camel@perches.com>
Currently, checkpatch.pl warns for BAD_SIGN_OFF on the usage of
non-standard signatures.
An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
non-standard signatures, 43 are due to the use of 'Co-authored-by'
tag, which may seem correct, but is not standard.
The standard signature equivalent for 'Co-authored-by' is
'Co-developed-by'.
Provide a fix by suggesting users with this signature alternative and
replacing.
Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
scripts/checkpatch.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4a026926139f..fc036d545d2d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2832,6 +2832,9 @@ sub process {
if ($sign_off !~ /$signature_tags/) {
my $suggested_signature = find_standard_signature($sign_off);
+ if ($sign_off =~ /co-authored-by:/i) {
+ $suggested_signature = "Co-developed-by:";
+ }
if ($suggested_signature eq "") {
WARN("BAD_SIGN_OFF",
"Non-standard signature: $sign_off\n" . $herecurr);
--
2.17.1
next prev parent reply other threads:[~2020-12-02 9:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:29 [PATCH v5] checkpatch: add fix and improve warning msg for Non-standard signature Aditya Srivastava
2020-12-01 17:24 ` Joe Perches
2020-12-01 18:21 ` Lukas Bulwahn
2020-12-01 18:39 ` Joe Perches
2020-12-02 9:08 ` Aditya Srivastava [this message]
2020-12-02 17:16 ` [PATCH] checkpatch: add fix for non-standard signature - co-authored-by Joe Perches
2020-12-02 18:30 ` [PATCH -mmots] " Aditya Srivastava
2020-12-02 18:56 ` Joe Perches
2020-12-03 9:59 ` Aditya
2020-12-03 10:59 ` Lukas Bulwahn
2020-12-03 12:23 ` Aditya
2020-12-03 18:57 ` [Linux-kernel-mentees] " Greg KH
2020-12-03 19:00 ` Lukas Bulwahn
2020-12-03 19:25 ` Greg KH
2020-12-03 19:31 ` Joe Perches
2020-12-04 14:40 ` [PATCH v6] " Aditya Srivastava
2020-12-04 15:59 ` Joe Perches
2020-12-05 10:22 ` Aditya
2020-12-05 12:03 ` Joe Perches
2020-12-05 12:55 ` Aditya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202090828.12934-1-yashsri421@gmail.com \
--to=yashsri421@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).