From: kernel test robot <lkp@intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rui.zhang@intel.com
Cc: kbuild-all@lists.01.org, amitk@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/4] thermal/core: Rename passive_delay and polling_delay with units
Date: Wed, 2 Dec 2020 23:18:40 +0800 [thread overview]
Message-ID: <202012022343.m32nIfWk-lkp@intel.com> (raw)
In-Reply-To: <20201202120657.1969-1-daniel.lezcano@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3469 bytes --]
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.10-rc6 next-20201201]
[cannot apply to thermal/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-core-Rename-passive_delay-and-polling_delay-with-units/20201202-201150
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576
config: i386-randconfig-a001-20201202 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/ade78f158731d79d859533d4370cc2a1294be32e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Rename-passive_delay-and-polling_delay-with-units/20201202-201150
git checkout ade78f158731d79d859533d4370cc2a1294be32e
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/platform/x86/acerhdf.c: In function 'acerhdf_check_param':
>> drivers/platform/x86/acerhdf.c:339:12: error: 'struct thermal_zone_device' has no member named 'polling_delay'; did you mean 'polling_delay_ms'?
339 | thermal->polling_delay = interval*1000;
| ^~~~~~~~~~~~~
| polling_delay_ms
vim +339 drivers/platform/x86/acerhdf.c
e86435eb91b2bff Peter Feuerer 2009-06-21 322
e86435eb91b2bff Peter Feuerer 2009-06-21 323 static void acerhdf_check_param(struct thermal_zone_device *thermal)
e86435eb91b2bff Peter Feuerer 2009-06-21 324 {
e86435eb91b2bff Peter Feuerer 2009-06-21 325 if (fanon > ACERHDF_MAX_FANON) {
e86435eb91b2bff Peter Feuerer 2009-06-21 326 pr_err("fanon temperature too high, set to %d\n",
e86435eb91b2bff Peter Feuerer 2009-06-21 327 ACERHDF_MAX_FANON);
e86435eb91b2bff Peter Feuerer 2009-06-21 328 fanon = ACERHDF_MAX_FANON;
e86435eb91b2bff Peter Feuerer 2009-06-21 329 }
e86435eb91b2bff Peter Feuerer 2009-06-21 330
e86435eb91b2bff Peter Feuerer 2009-06-21 331 if (kernelmode && prev_interval != interval) {
e86435eb91b2bff Peter Feuerer 2009-06-21 332 if (interval > ACERHDF_MAX_INTERVAL) {
e86435eb91b2bff Peter Feuerer 2009-06-21 333 pr_err("interval too high, set to %d\n",
e86435eb91b2bff Peter Feuerer 2009-06-21 334 ACERHDF_MAX_INTERVAL);
e86435eb91b2bff Peter Feuerer 2009-06-21 335 interval = ACERHDF_MAX_INTERVAL;
e86435eb91b2bff Peter Feuerer 2009-06-21 336 }
e86435eb91b2bff Peter Feuerer 2009-06-21 337 if (verbose)
eecc5bbc612a8b0 Joe Perches 2011-11-29 338 pr_notice("interval changed to: %d\n", interval);
e86435eb91b2bff Peter Feuerer 2009-06-21 @339 thermal->polling_delay = interval*1000;
e86435eb91b2bff Peter Feuerer 2009-06-21 340 prev_interval = interval;
e86435eb91b2bff Peter Feuerer 2009-06-21 341 }
e86435eb91b2bff Peter Feuerer 2009-06-21 342 }
e86435eb91b2bff Peter Feuerer 2009-06-21 343
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34253 bytes --]
next prev parent reply other threads:[~2020-12-02 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:06 [PATCH 1/4] thermal/core: Rename passive_delay and polling_delay with units Daniel Lezcano
2020-12-02 12:06 ` [PATCH 2/4] thermal/core: Precompute the jiffies Daniel Lezcano
2020-12-15 14:38 ` Thara Gopinath
2020-12-15 22:58 ` Daniel Lezcano
2020-12-02 12:06 ` [PATCH 3/4] thermal/core: Use precomputed jiffies for the polling Daniel Lezcano
2020-12-02 12:06 ` [PATCH 4/4] thermal/core: Remove ms based delay fields Daniel Lezcano
2020-12-02 17:26 ` kernel test robot
2020-12-02 17:44 ` kernel test robot
2020-12-02 15:18 ` kernel test robot [this message]
2020-12-02 16:14 ` [PATCH 1/4] thermal/core: Rename passive_delay and polling_delay with units kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012022343.m32nIfWk-lkp@intel.com \
--to=lkp@intel.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).