From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: rui.zhang@intel.com, amitk@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/4] thermal/core: Precompute the jiffies
Date: Tue, 15 Dec 2020 23:58:32 +0100 [thread overview]
Message-ID: <20201215225832.GB3581@linaro.org> (raw)
In-Reply-To: <1c909a38-1777-556d-fe87-29394a1b1d56@linaro.org>
On Tue, Dec 15, 2020 at 09:38:06AM -0500, Thara Gopinath wrote:
> Hi Daniel,
>
> On 12/2/20 7:06 AM, Daniel Lezcano wrote:
> > The delays are stored in ms units and when the polling function is
> > called this delay is converted into jiffies at each call.
> >
> > Instead of doing the conversion again and again, compute the jiffies
> > at init time and use the value directly when setting the polling.
>
> A generic comment. You can avoid patch 1 of this series and directly
> have patch 2 , right? There is no need to rename polling_delay/passive_delay
> to *_delay_ms and then remove it again?
Yes, I can simplify that.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > ---
[ ... ]
> > +static inline void thermal_zone_set_polling_delay(
> > + struct thermal_zone_device *tz, int delay_ms)
> > +{
> > + tz->polling_delay_ms = delay_ms;
> > + tz->polling_delay_jiffies = msecs_to_jiffies(delay_ms);
> > + if (delay_ms > 1000)
> > + tz->polling_delay_jiffies = round_jiffies(tz->polling_delay_jiffies);
> > +}
>
> How about one function instead?
> static inline void thermal_zone_set_delay_jiffies(int *delay_jiffes, int
> delay_ms)
> {
> *delay_jiffies = msecs_to_jiffies(delay_ms);
> if (delay_ms > 1000)
> *delay_jiffies = round_jiffies(*delay_jiffies);
> }
>
> And then calling thermal_zone_set_delay_jiffies(&tz->passive_delay_jiffies,
> passive_delay)..
Yes, agree. I'll do this change.
Thanks for the review
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-12-15 22:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:06 [PATCH 1/4] thermal/core: Rename passive_delay and polling_delay with units Daniel Lezcano
2020-12-02 12:06 ` [PATCH 2/4] thermal/core: Precompute the jiffies Daniel Lezcano
2020-12-15 14:38 ` Thara Gopinath
2020-12-15 22:58 ` Daniel Lezcano [this message]
2020-12-02 12:06 ` [PATCH 3/4] thermal/core: Use precomputed jiffies for the polling Daniel Lezcano
2020-12-02 12:06 ` [PATCH 4/4] thermal/core: Remove ms based delay fields Daniel Lezcano
2020-12-02 17:26 ` kernel test robot
2020-12-02 17:44 ` kernel test robot
2020-12-02 15:18 ` [PATCH 1/4] thermal/core: Rename passive_delay and polling_delay with units kernel test robot
2020-12-02 16:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215225832.GB3581@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).