From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rui.zhang@intel.com, kai.heng.feng@canonical.com,
lukasz.luba@arm.com, srinivas.pandruvada@linux.intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Amit Kucheria <amitk@kernel.org>,
"open list:RENESAS R-CAR THERMAL DRIVERS"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 4/5] thermal/drivers/rcar: Remove notification usage
Date: Thu, 10 Dec 2020 17:10:22 +0100 [thread overview]
Message-ID: <20201210161022.GE4186812@oden.dyn.berto.se> (raw)
In-Reply-To: <20201210121514.25760-4-daniel.lezcano@linaro.org>
Hi Daniel,
Thanks for your work.
On 2020-12-10 13:15:13 +0100, Daniel Lezcano wrote:
> The ops is only showing a trace telling a critical trip point is
> crossed. The same information is given by the thermal framework.
>
> This is redundant, remove the code.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/thermal/rcar_thermal.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index 6ae757d66f46..b49f04daaf47 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -323,24 +323,6 @@ static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone,
> return 0;
> }
>
> -static int rcar_thermal_notify(struct thermal_zone_device *zone,
> - int trip, enum thermal_trip_type type)
> -{
> - struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
> - struct device *dev = rcar_priv_to_dev(priv);
> -
> - switch (type) {
> - case THERMAL_TRIP_CRITICAL:
> - /* FIXME */
> - dev_warn(dev, "Thermal reached to critical temperature\n");
> - break;
> - default:
> - break;
> - }
> -
> - return 0;
> -}
> -
> static const struct thermal_zone_of_device_ops rcar_thermal_zone_of_ops = {
> .get_temp = rcar_thermal_of_get_temp,
> };
> @@ -349,7 +331,6 @@ static struct thermal_zone_device_ops rcar_thermal_zone_ops = {
> .get_temp = rcar_thermal_get_temp,
> .get_trip_type = rcar_thermal_get_trip_type,
> .get_trip_temp = rcar_thermal_get_trip_temp,
> - .notify = rcar_thermal_notify,
> };
>
> /*
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2020-12-10 16:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 12:15 [PATCH 1/5] thermal/core: Emit a warning if the thermal zone is updated without ops Daniel Lezcano
2020-12-10 12:15 ` [PATCH 2/5] thermal/core: Add critical and hot ops Daniel Lezcano
2020-12-10 12:44 ` Lukasz Luba
2020-12-10 13:37 ` Daniel Lezcano
2020-12-10 13:51 ` Lukasz Luba
2020-12-10 12:15 ` [PATCH 3/5] thermal/drivers/acpi: Use hot and critical ops Daniel Lezcano
2020-12-17 6:28 ` Daniel Lezcano
2020-12-17 11:38 ` Srinivas Pandruvada
2020-12-17 13:10 ` Daniel Lezcano
2020-12-10 12:15 ` [PATCH 4/5] thermal/drivers/rcar: Remove notification usage Daniel Lezcano
2020-12-10 16:10 ` Niklas Söderlund [this message]
2020-12-10 12:15 ` [PATCH 5/5] thermal/core: Remove notify ops Daniel Lezcano
2020-12-10 14:37 ` Lukasz Luba
2020-12-14 14:40 ` [thermal: thermal/next] thermal/core: Emit a warning if the thermal zone is updated without ops thermal-bot for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210161022.GE4186812@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).