From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rui.zhang@intel.com
Cc: kai.heng.feng@canonical.com, lukasz.luba@arm.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"open list:ACPI THERMAL DRIVER" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 3/5] thermal/drivers/acpi: Use hot and critical ops
Date: Thu, 17 Dec 2020 03:38:08 -0800 [thread overview]
Message-ID: <2b101b07aa18e06a32b26add651a3d2e009e6d18.camel@linux.intel.com> (raw)
In-Reply-To: <c20d9077-66e8-f947-6422-c48e2f679cc5@linaro.org>
On Thu, 2020-12-17 at 07:28 +0100, Daniel Lezcano wrote:
> On 10/12/2020 13:15, Daniel Lezcano wrote:
> > The acpi driver wants to do a netlink notification in case of a hot
> > or
> > critical trip point. Implement the corresponding ops to be used for
> > the thermal zone and use them instead of the notify ops.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> Is there any comment on this patch ?
Looks good to me.
Thanks,
Srinivas
>
> > ---
> > drivers/acpi/thermal.c | 30 ++++++++++++++----------------
> > 1 file changed, 14 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> > index 12c0ece746f0..b5e4bc9e3282 100644
> > --- a/drivers/acpi/thermal.c
> > +++ b/drivers/acpi/thermal.c
> > @@ -677,27 +677,24 @@ static int thermal_get_trend(struct
> > thermal_zone_device *thermal,
> > return 0;
> > }
> >
> > -
> > -static int thermal_notify(struct thermal_zone_device *thermal, int
> > trip,
> > - enum thermal_trip_type trip_type)
> > +static void acpi_thermal_zone_device_hot(struct
> > thermal_zone_device *thermal)
> > {
> > - u8 type = 0;
> > struct acpi_thermal *tz = thermal->devdata;
> >
> > - if (trip_type == THERMAL_TRIP_CRITICAL)
> > - type = ACPI_THERMAL_NOTIFY_CRITICAL;
> > - else if (trip_type == THERMAL_TRIP_HOT)
> > - type = ACPI_THERMAL_NOTIFY_HOT;
> > - else
> > - return 0;
> > -
> > acpi_bus_generate_netlink_event(tz->device-
> > >pnp.device_class,
> > - dev_name(&tz->device->dev),
> > type, 1);
> > + dev_name(&tz->device->dev),
> > + ACPI_THERMAL_NOTIFY_HOT,
> > 1);
> > +}
> >
> > - if (trip_type == THERMAL_TRIP_CRITICAL && nocrt)
> > - return 1;
> > +static void acpi_thermal_zone_device_critical(struct
> > thermal_zone_device *thermal)
> > +{
> > + struct acpi_thermal *tz = thermal->devdata;
> >
> > - return 0;
> > + acpi_bus_generate_netlink_event(tz->device-
> > >pnp.device_class,
> > + dev_name(&tz->device->dev),
> > + ACPI_THERMAL_NOTIFY_CRITICA
> > L, 1);
> > +
> > + thermal_zone_device_critical(thermal);
> > }
> >
> > static int acpi_thermal_cooling_device_cb(struct
> > thermal_zone_device *thermal,
> > @@ -812,7 +809,8 @@ static struct thermal_zone_device_ops
> > acpi_thermal_zone_ops = {
> > .get_trip_temp = thermal_get_trip_temp,
> > .get_crit_temp = thermal_get_crit_temp,
> > .get_trend = thermal_get_trend,
> > - .notify = thermal_notify,
> > + .hot = acpi_thermal_zone_device_hot,
> > + .critical = acpi_thermal_zone_device_critical,
> > };
> >
> > static int acpi_thermal_register_thermal_zone(struct acpi_thermal
> > *tz)
> >
>
>
next prev parent reply other threads:[~2020-12-17 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 12:15 [PATCH 1/5] thermal/core: Emit a warning if the thermal zone is updated without ops Daniel Lezcano
2020-12-10 12:15 ` [PATCH 2/5] thermal/core: Add critical and hot ops Daniel Lezcano
2020-12-10 12:44 ` Lukasz Luba
2020-12-10 13:37 ` Daniel Lezcano
2020-12-10 13:51 ` Lukasz Luba
2020-12-10 12:15 ` [PATCH 3/5] thermal/drivers/acpi: Use hot and critical ops Daniel Lezcano
2020-12-17 6:28 ` Daniel Lezcano
2020-12-17 11:38 ` Srinivas Pandruvada [this message]
2020-12-17 13:10 ` Daniel Lezcano
2020-12-10 12:15 ` [PATCH 4/5] thermal/drivers/rcar: Remove notification usage Daniel Lezcano
2020-12-10 16:10 ` Niklas Söderlund
2020-12-10 12:15 ` [PATCH 5/5] thermal/core: Remove notify ops Daniel Lezcano
2020-12-10 14:37 ` Lukasz Luba
2020-12-14 14:40 ` [thermal: thermal/next] thermal/core: Emit a warning if the thermal zone is updated without ops thermal-bot for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b101b07aa18e06a32b26add651a3d2e009e6d18.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=kai.heng.feng@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).