From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] iio:common:ms_sensors:ms_sensors_i2c: add support for alternative PROM layout
Date: Sun, 13 Dec 2020 20:34:36 +0100 [thread overview]
Message-ID: <20201213193436.GM1781038@piout.net> (raw)
In-Reply-To: <20201213172042.76b2e028@archlinux>
On 13/12/2020 17:20:42+0000, Jonathan Cameron wrote:
> > +/**
> > + * ms_sensors_tp_crc_valid_112() - CRC check function for
> > + * Temperature and pressure devices for 112bit PROM.
> > + * This function is only used when reading PROM coefficients
> > + *
> > + * @prom: pointer to PROM coefficients array
> > + *
> > + * Return: CRC.
>
> That's a bit confusing. Perhaps return if CRC correct
> Sometimes CRC is used to refer to particular bits and sometimes
> to the check (i.e. whether it is right).
>
Roght, this should have been "Return: True if CRC is ok."
> > + */
> > +static bool ms_sensors_tp_crc_valid_112(u16 *prom)
> > +{
> > + u16 w0 = prom[0], crc_read = (w0 & 0xF000) >> 12;
> > + u8 crc;
> > +
> > + prom[0] &= 0x0FFF; /* Clear the CRC computation part */
> > + prom[MS_SENSORS_TP_PROM_WORDS_NB - 1] = 0;
> > +
> > + crc = ms_sensors_tp_crc4(prom);
> > +
> > + prom[0] = w0;
> > +
> > + return crc == crc_read;
> > +}
> > +
> > +/**
> > + * ms_sensors_tp_crc_valid_128() - CRC check function for
> > + * Temperature and pressure devices for 128bit PROM.
> > + * This function is only used when reading PROM coefficients
> > + *
> > + * @prom: pointer to PROM coefficients array
> > + *
> > + * Return: CRC.
> > + */
> > +static bool ms_sensors_tp_crc_valid_128(u16 *prom)
> > +{
> > + u16 w7 = prom[7], crc_read = w7 & 0x000F;
> > + u8 crc;
> > +
> > + prom[7] &= 0xFF00; /* Clear the CRC and LSB part */
> > +
> > + crc = ms_sensors_tp_crc4(prom);
> > +
> > + prom[7] = w7;
> > +
> > + return crc == crc_read;
> > }
> >
> > /**
> > @@ -535,6 +577,7 @@ static bool ms_sensors_tp_crc_valid(u16 *prom)
> > int ms_sensors_tp_read_prom(struct ms_tp_dev *dev_data)
> > {
> > int i, ret;
> > + bool valid;
> >
> > for (i = 0; i < dev_data->hw->prom_len; i++) {
> > ret = ms_sensors_read_prom_word(
> > @@ -546,7 +589,12 @@ int ms_sensors_tp_read_prom(struct ms_tp_dev *dev_data)
> > return ret;
> > }
> >
> > - if (!ms_sensors_tp_crc_valid(dev_data->prom)) {
> > + if (dev_data->hw->prom_len == 8)
> > + valid = ms_sensors_tp_crc_valid_128(dev_data->prom);
> > + else
> > + valid = ms_sensors_tp_crc_valid_112(dev_data->prom);
> > +
> > + if (!valid) {
> > dev_err(&dev_data->client->dev,
> > "Calibration coefficients crc check error\n");
> > return -ENODEV;
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-12-13 19:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 23:48 [PATCH 0/6] iio:pressure:ms5637: add ms5803 support Alexandre Belloni
2020-12-09 23:48 ` [PATCH 1/6] iio:pressure:ms5637: switch to probe_new Alexandre Belloni
2020-12-12 13:26 ` Andy Shevchenko
2020-12-13 17:04 ` Jonathan Cameron
2020-12-09 23:48 ` [PATCH 2/6] iio:pressure:ms5637: introduce hardware differentiation Alexandre Belloni
2020-12-13 17:12 ` Jonathan Cameron
2020-12-13 19:51 ` Alexandre Belloni
2020-12-09 23:48 ` [PATCH 3/6] iio:pressure:ms5637: limit available sample frequencies Alexandre Belloni
2020-12-12 18:26 ` Andy Shevchenko
2020-12-13 17:17 ` Jonathan Cameron
2020-12-09 23:48 ` [PATCH 4/6] iio:common:ms_sensors:ms_sensors_i2c: rework CRC calculation helper Alexandre Belloni
2020-12-09 23:48 ` [PATCH 5/6] iio:common:ms_sensors:ms_sensors_i2c: add support for alternative PROM layout Alexandre Belloni
2020-12-13 17:20 ` Jonathan Cameron
2020-12-13 19:34 ` Alexandre Belloni [this message]
2020-12-09 23:48 ` [PATCH 6/6] iio:pressure:ms5637: add ms5803 support Alexandre Belloni
2020-12-11 3:34 ` Rob Herring
2020-12-11 8:08 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201213193436.GM1781038@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).