* [PATCH 0/4] small Librem 5 phone dts updates
@ 2020-12-18 10:31 Martin Kepplinger
2020-12-18 10:31 ` [PATCH 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 Martin Kepplinger
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Martin Kepplinger @ 2020-12-18 10:31 UTC (permalink / raw)
To: robh, shawnguo, festevam
Cc: kernel, linux-imx, krzk, kernel, devicetree, linux-arm-kernel,
linux-kernel, Martin Kepplinger
Some minor updates for the current hardware descriptions:
Martin Kepplinger (4):
arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8
arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen
description
arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT
arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu
voltage
.../boot/dts/freescale/imx8mq-librem5-r3.dts | 6 ++++
.../boot/dts/freescale/imx8mq-librem5.dtsi | 28 ++++++++++++++-----
2 files changed, 27 insertions(+), 7 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8
2020-12-18 10:31 [PATCH 0/4] small Librem 5 phone dts updates Martin Kepplinger
@ 2020-12-18 10:31 ` Martin Kepplinger
2020-12-18 10:31 ` [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description Martin Kepplinger
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Martin Kepplinger @ 2020-12-18 10:31 UTC (permalink / raw)
To: robh, shawnguo, festevam
Cc: kernel, linux-imx, krzk, kernel, devicetree, linux-arm-kernel,
linux-kernel, Martin Kepplinger
buck7 is the supply here. Also, fix alphabetical ordering.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 64fc546b110f..55268fc0622e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -99,6 +99,14 @@
regulator-max-microvolt = <3300000>;
};
+ reg_vdd_1v8: regulator-vdd-1v8 {
+ compatible = "regulator-fixed";
+ regulator-name = "VDD_1V8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ vin-supply = <&buck7_reg>;
+ };
+
reg_vdd_3v3: regulator-vdd-3v3 {
compatible = "regulator-fixed";
regulator-name = "VDD_3V3";
@@ -106,13 +114,6 @@
regulator-max-microvolt = <3300000>;
};
- reg_vdd_1v8: regulator-vdd-1v8 {
- compatible = "regulator-fixed";
- regulator-name = "VCC_1V8";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- };
-
reg_vsys_3v4: regulator-vsys-3v4 {
compatible = "regulator-fixed";
regulator-name = "VSYS_3V4";
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description
2020-12-18 10:31 [PATCH 0/4] small Librem 5 phone dts updates Martin Kepplinger
2020-12-18 10:31 ` [PATCH 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 Martin Kepplinger
@ 2020-12-18 10:31 ` Martin Kepplinger
2020-12-19 12:20 ` Krzysztof Kozlowski
2020-12-18 10:31 ` [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT Martin Kepplinger
2020-12-18 10:31 ` [PATCH 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage Martin Kepplinger
3 siblings, 1 reply; 7+ messages in thread
From: Martin Kepplinger @ 2020-12-18 10:31 UTC (permalink / raw)
To: robh, shawnguo, festevam
Cc: kernel, linux-imx, krzk, kernel, devicetree, linux-arm-kernel,
linux-kernel, Martin Kepplinger
Add the pinctrl description for the interrupt.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 55268fc0622e..a60df09d90f7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -459,6 +459,13 @@
>;
};
+ pinctrl_touch: touchgrp {
+ fsl,pins = <
+ /* TP_INT */
+ MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27 0x80
+ >;
+ };
+
pinctrl_typec: typecgrp {
fsl,pins = <
/* TYPEC_MUX_EN */
@@ -880,6 +887,8 @@
touchscreen@38 {
compatible = "edt,edt-ft5506";
reg = <0x38>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_touch>;
interrupt-parent = <&gpio1>;
interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
touchscreen-size-x = <720>;
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT
2020-12-18 10:31 [PATCH 0/4] small Librem 5 phone dts updates Martin Kepplinger
2020-12-18 10:31 ` [PATCH 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 Martin Kepplinger
2020-12-18 10:31 ` [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description Martin Kepplinger
@ 2020-12-18 10:31 ` Martin Kepplinger
2020-12-19 12:21 ` Krzysztof Kozlowski
2020-12-18 10:31 ` [PATCH 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage Martin Kepplinger
3 siblings, 1 reply; 7+ messages in thread
From: Martin Kepplinger @ 2020-12-18 10:31 UTC (permalink / raw)
To: robh, shawnguo, festevam
Cc: kernel, linux-imx, krzk, kernel, devicetree, linux-arm-kernel,
linux-kernel, Martin Kepplinger
According to commit e045f044e84e ("arm64: dts: imx8mq: Move usdhc clocks
assignment to board DT") add the clocks assignment to imx8mq-librem5.dtsi
too.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index a60df09d90f7..47e70ba4e4f1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1082,6 +1082,8 @@
};
&usdhc1 {
+ assigned-clocks = <&clk IMX8MQ_CLK_USDHC1>;
+ assigned-clock-rates = <400000000>;
pinctrl-names = "default", "state_100mhz", "state_200mhz";
pinctrl-0 = <&pinctrl_usdhc1>;
pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
@@ -1094,6 +1096,8 @@
};
&usdhc2 {
+ assigned-clocks = <&clk IMX8MQ_CLK_USDHC2>;
+ assigned-clock-rates = <200000000>;
pinctrl-names = "default", "state_100mhz", "state_200mhz";
pinctrl-0 = <&pinctrl_usdhc2>;
pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage
2020-12-18 10:31 [PATCH 0/4] small Librem 5 phone dts updates Martin Kepplinger
` (2 preceding siblings ...)
2020-12-18 10:31 ` [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT Martin Kepplinger
@ 2020-12-18 10:31 ` Martin Kepplinger
3 siblings, 0 replies; 7+ messages in thread
From: Martin Kepplinger @ 2020-12-18 10:31 UTC (permalink / raw)
To: robh, shawnguo, festevam
Cc: kernel, linux-imx, krzk, kernel, devicetree, linux-arm-kernel,
linux-kernel, Martin Kepplinger
This is a workaround for a hardware bug in the r3 revision that basically would
stop the system due to traffic on the i2c1 bus. A cpu voltage change would
trigger such traffic and that's what is avoided in order to work around it.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
index 6704ea2c72a3..0d38327043f8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
@@ -10,6 +10,12 @@
compatible = "purism,librem5r3", "purism,librem5", "fsl,imx8mq";
};
+&a53_opp_table {
+ opp-1000000000 {
+ opp-microvolt = <1000000>;
+ };
+};
+
&accel_gyro {
mount-matrix = "1", "0", "0",
"0", "1", "0",
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description
2020-12-18 10:31 ` [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description Martin Kepplinger
@ 2020-12-19 12:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-19 12:20 UTC (permalink / raw)
To: Martin Kepplinger
Cc: robh, shawnguo, festevam, kernel, linux-imx, kernel, devicetree,
linux-arm-kernel, linux-kernel
On Fri, Dec 18, 2020 at 11:31:29AM +0100, Martin Kepplinger wrote:
> Add the pinctrl description for the interrupt.
Please describe why do you need to add it. From the patch contents I
easily see what you are doing. But neither the commit title nor the
message describe what you want to achieve (why are you doing it).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT
2020-12-18 10:31 ` [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT Martin Kepplinger
@ 2020-12-19 12:21 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-19 12:21 UTC (permalink / raw)
To: Martin Kepplinger
Cc: robh, shawnguo, festevam, kernel, linux-imx, kernel, devicetree,
linux-arm-kernel, linux-kernel
On Fri, Dec 18, 2020 at 11:31:30AM +0100, Martin Kepplinger wrote:
> According to commit e045f044e84e ("arm64: dts: imx8mq: Move usdhc clocks
> assignment to board DT") add the clocks assignment to imx8mq-librem5.dtsi
> too.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
This should go with Fixes tag as well.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-12-19 12:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18 10:31 [PATCH 0/4] small Librem 5 phone dts updates Martin Kepplinger
2020-12-18 10:31 ` [PATCH 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 Martin Kepplinger
2020-12-18 10:31 ` [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description Martin Kepplinger
2020-12-19 12:20 ` Krzysztof Kozlowski
2020-12-18 10:31 ` [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT Martin Kepplinger
2020-12-19 12:21 ` Krzysztof Kozlowski
2020-12-18 10:31 ` [PATCH 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage Martin Kepplinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).