From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Tomasz Figa <tfiga@google.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
anan.sun@mediatek.com, yi.kuo@mediatek.com
Subject: Re: [PATCH 3/3] memory: mtk-smi: Switch MTK_SMI to tristate
Date: Fri, 22 Jan 2021 22:35:58 +0100 [thread overview]
Message-ID: <20210122213558.qnboqc4obdmipxs4@kozik-lap> (raw)
In-Reply-To: <20210121062429.26504-4-yong.wu@mediatek.com>
On Thu, Jan 21, 2021 at 02:24:29PM +0800, Yong Wu wrote:
> This patch switches MTK_SMI to tristate. Support it could be 'm'.
>
> Meanwhile, Fix a build issue while MTK_SMI is built as module.
s/Fix/fix.
What error is being fixed here? How can I reproduce it? Aren't you just
adjusting it to being buildable by module?
Best regards,
Krzysztof
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> This patch has a little conflict with the mt8192 iommu patch which
> delete the MTK_LARB_NR_MAX in smi.h(It's still reviewing).
> This patch rebase on the clean v5.11-rc1.
> ---
> drivers/memory/Kconfig | 2 +-
> include/soc/mediatek/smi.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 3ea6913df176..d5f0f4680880 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -173,7 +173,7 @@ config JZ4780_NEMC
> memory devices such as NAND and SRAM.
>
> config MTK_SMI
> - bool "Mediatek SoC Memory Controller driver" if COMPILE_TEST
> + tristate "Mediatek SoC Memory Controller driver" if COMPILE_TEST
> depends on ARCH_MEDIATEK || COMPILE_TEST
> help
> This driver is for the Memory Controller module in MediaTek SoCs,
> diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h
> index 5a34b87d89e3..29e2fb8f33d6 100644
> --- a/include/soc/mediatek/smi.h
> +++ b/include/soc/mediatek/smi.h
> @@ -9,7 +9,7 @@
> #include <linux/bitops.h>
> #include <linux/device.h>
>
> -#ifdef CONFIG_MTK_SMI
> +#if IS_ENABLED(CONFIG_MTK_SMI)
next prev parent reply other threads:[~2021-01-22 21:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:24 Support MTK_SMI modular Yong Wu
2021-01-21 6:24 ` [PATCH 1/3] memory: mtk-smi: Use platform_register_drivers Yong Wu
2021-01-22 21:31 ` Krzysztof Kozlowski
2021-01-21 6:24 ` [PATCH 2/3] memory: mtk-smi: Add module_exit and module_license Yong Wu
2021-01-22 21:34 ` Krzysztof Kozlowski
2021-01-25 6:49 ` Yong Wu
2021-01-25 8:40 ` Krzysztof Kozlowski
2021-01-25 9:28 ` Yong Wu
2021-01-25 10:40 ` Krzysztof Kozlowski
2021-01-26 6:12 ` Yong Wu
2021-01-21 6:24 ` [PATCH 3/3] memory: mtk-smi: Switch MTK_SMI to tristate Yong Wu
2021-01-22 21:35 ` Krzysztof Kozlowski [this message]
2021-01-25 6:49 ` Yong Wu
2021-01-25 8:44 ` Krzysztof Kozlowski
2021-01-25 10:11 ` Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122213558.qnboqc4obdmipxs4@kozik-lap \
--to=krzk@kernel.org \
--cc=anan.sun@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).