From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Tomasz Figa <tfiga@google.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
anan.sun@mediatek.com, yi.kuo@mediatek.com
Subject: Re: [PATCH 2/3] memory: mtk-smi: Add module_exit and module_license
Date: Mon, 25 Jan 2021 09:40:51 +0100 [thread overview]
Message-ID: <20210125084051.ipgeu2ksucdag2u4@kozik-lap> (raw)
In-Reply-To: <1611557381.3184.21.camel@mhfsdcap03>
On Mon, Jan 25, 2021 at 02:49:41PM +0800, Yong Wu wrote:
> On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote:
> > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote:
> > > The config MTK_SMI always depends on MTK_IOMMU which is built-in
> > > currently. Thus we don't have module_exit before. This patch adds
> > > module_exit and module_license. It is a preparing patch for supporting
> > > MTK_SMI could been built as a module.
> > >
> > > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > > ---
> > > drivers/memory/mtk-smi.c | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> > > index e2aebd2bfa8e..aa2a25abf04f 100644
> > > --- a/drivers/memory/mtk-smi.c
> > > +++ b/drivers/memory/mtk-smi.c
> > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void)
> > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers));
> > > }
> > > module_init(mtk_smi_init);
> > > +
> > > +static void __exit mtk_smi_exit(void)
> > > +{
> > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers));
> > > +}
> > > +module_exit(mtk_smi_exit);
> > > +
> > > +MODULE_DESCRIPTION("MediaTek SMI driver");
> > > +MODULE_ALIAS("platform:MediaTek-SMI");
> >
> > Drivers do not use capital letters, so I have doubts whether this alias
> > is correct.
>
> I didn't care the upper/lower-case. I will change to lower case in next
> time.
Then why do you need the alias? The name does not match driver name, so
what's the purpose of this alias/
>
> MODULE_ALIAS("platform:MediaTek-smi")
>
> >
> > Adding all these should be squashed with changing Kconfig into tristate.
> > It does not have sense on its own.
>
> Thanks very much for review.
>
> Only confirm: Squash whole this patch or only squash the MODULE_x into
> the next patch?
This entire patch 2/3 should be with 3/3.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-01-25 8:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:24 Support MTK_SMI modular Yong Wu
2021-01-21 6:24 ` [PATCH 1/3] memory: mtk-smi: Use platform_register_drivers Yong Wu
2021-01-22 21:31 ` Krzysztof Kozlowski
2021-01-21 6:24 ` [PATCH 2/3] memory: mtk-smi: Add module_exit and module_license Yong Wu
2021-01-22 21:34 ` Krzysztof Kozlowski
2021-01-25 6:49 ` Yong Wu
2021-01-25 8:40 ` Krzysztof Kozlowski [this message]
2021-01-25 9:28 ` Yong Wu
2021-01-25 10:40 ` Krzysztof Kozlowski
2021-01-26 6:12 ` Yong Wu
2021-01-21 6:24 ` [PATCH 3/3] memory: mtk-smi: Switch MTK_SMI to tristate Yong Wu
2021-01-22 21:35 ` Krzysztof Kozlowski
2021-01-25 6:49 ` Yong Wu
2021-01-25 8:44 ` Krzysztof Kozlowski
2021-01-25 10:11 ` Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125084051.ipgeu2ksucdag2u4@kozik-lap \
--to=krzk@kernel.org \
--cc=anan.sun@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).