linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: kostap@marvell.com
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	robh+dt@kernel.org, sebastian.hesselbarth@gmail.com,
	gregory.clement@bootlin.com, andrew@lunn.ch, mw@semihalf.com,
	jaz@semihalf.com, nadavh@marvell.com, stefanc@marvell.com,
	bpeled@marvell.com
Subject: Re: [PATCH v2 05/12] arm64: dts: marvell: armada-3720-db: add comphy references
Date: Fri, 12 Feb 2021 00:31:36 +0100	[thread overview]
Message-ID: <20210211233136.t36ytezz4n6lbtmn@pali> (raw)
In-Reply-To: <20210210140949.32515-6-kostap@marvell.com>

On Wednesday 10 February 2021 16:09:42 kostap@marvell.com wrote:
> From: Grzegorz Jaszczyk <jaz@semihalf.com>
> 
> Adding phy description to pcie, sata and usb will allow appropriate drivers
> to configure marvell comphy-a3700 accordingly.
> 
> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>

Hello! This patch is not needed too as Gregory already included into his
tree alternative patch which defines SATA PHY globally into main include
file armada-37xx.dtsi:

https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/commit/?h=for-next&id=6ece0f7dbd558670ec72ba390379949a4d4dc5c0

And PCIe and USB 3.0 PHY definitions are already in include file.

> ---
>  arch/arm64/boot/dts/marvell/armada-3720-db.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> index 3e5789f37206..15e923f945d4 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> @@ -132,11 +132,15 @@
>  	pinctrl-0 = <&pcie_reset_pins &pcie_clkreq_pins>;
>  	reset-gpios = <&gpiosb 3 GPIO_ACTIVE_LOW>;
>  	status = "okay";
> +	/* Generic PHY, providing serdes lanes */
> +	phys = <&comphy1 0>;
>  };
>  
>  /* CON3 */
>  &sata {
>  	status = "okay";
> +	/* Generic PHY, providing serdes lanes */
> +	phys = <&comphy2 0>;
>  };
>  
>  &sdhci0 {
> @@ -217,4 +221,7 @@
>  &usb3 {
>  	status = "okay";
>  	usb-phy = <&usb3_phy>;
> +	/* Generic PHY, providing serdes lanes */
> +	phys = <&comphy0 0>;
> +	phy-names = "usb";
>  };
> -- 
> 2.17.1
> 

  reply	other threads:[~2021-02-11 23:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 14:09 [PATCH v2 00/12] Device tree fixes for Armada family kostap
2021-02-10 14:09 ` [PATCH v2 01/12] fix: arm64: dts: replace wrong regulator on ap emmc kostap
2021-02-11 10:52   ` Russell King - ARM Linux admin
2021-02-11 13:57     ` [EXT] " Kostya Porotchkin
2021-02-11 14:02       ` Russell King - ARM Linux admin
2021-02-10 14:09 ` [PATCH v2 02/12] dts: mvebu: Update A8K AP806/AP807 SDHCI settings kostap
2021-02-11 10:42   ` Russell King - ARM Linux admin
2021-02-10 14:09 ` [PATCH v2 03/12] dts: mvebu: Add pin control definitions for SDIO interafce kostap
2021-02-10 14:09 ` [PATCH v2 04/12] fix: dts: a8k: Add CP eMMC regulator and update device parameters kostap
2021-02-10 14:09 ` [PATCH v2 05/12] arm64: dts: marvell: armada-3720-db: add comphy references kostap
2021-02-11 23:31   ` Pali Rohár [this message]
2021-02-10 14:09 ` [PATCH v2 06/12] arm64: dts: marvell: armada-3270-espressobin: " kostap
2021-02-11 23:28   ` Pali Rohár
2021-02-10 14:09 ` [PATCH v2 07/12] fix: ARM64: dts: cp110: Switch to 8-bit ECC NAND setting kostap
2021-02-10 14:09 ` [PATCH v2 08/12] arm64: dts: marvell: armada-3720-db: add eeprom description kostap
2021-02-10 14:09 ` [PATCH v2 09/12] dts: a3700: enable dma coherence kostap
2021-02-10 14:09 ` [PATCH v2 10/12] dts: marvell: add 2 eeprom properties to A8K DB device tree kostap
2021-02-10 14:09 ` [PATCH v2 11/12] dts: marvell: add 2 eeprom properties to A7K " kostap
2021-02-10 14:09 ` [PATCH v2 12/12] arm64: dts: fix the Armada 8040 DB AP SDHCI bus width kostap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210211233136.t36ytezz4n6lbtmn@pali \
    --to=pali@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bpeled@marvell.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jaz@semihalf.com \
    --cc=kostap@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=stefanc@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).