* [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer()
@ 2021-04-08 11:23 Pu Lehui
2021-04-08 11:30 ` Michal Simek
2021-04-14 7:57 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Pu Lehui @ 2021-04-08 11:23 UTC (permalink / raw)
To: michal.simek
Cc: linux-arm-kernel, linux-i2c, linux-kernel, pulehui, yangjihong1,
zhangjinhao2
pm_runtime_get_sync() will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get() to keep usage
counter balanced.
Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
drivers/i2c/busses/i2c-cadence.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index e4b7f2a951ad..e8eae8725900 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -789,7 +789,7 @@ static int cdns_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
bool change_role = false;
#endif
- ret = pm_runtime_get_sync(id->dev);
+ ret = pm_runtime_resume_and_get(id->dev);
if (ret < 0)
return ret;
@@ -911,7 +911,7 @@ static int cdns_reg_slave(struct i2c_client *slave)
if (slave->flags & I2C_CLIENT_TEN)
return -EAFNOSUPPORT;
- ret = pm_runtime_get_sync(id->dev);
+ ret = pm_runtime_resume_and_get(id->dev);
if (ret < 0)
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer()
2021-04-08 11:23 [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer() Pu Lehui
@ 2021-04-08 11:30 ` Michal Simek
2021-04-14 7:57 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2021-04-08 11:30 UTC (permalink / raw)
To: Pu Lehui, michal.simek, Raviteja Narayanam, Shubhrajyoti Datta
Cc: linux-arm-kernel, linux-i2c, linux-kernel, yangjihong1, zhangjinhao2
On 4/8/21 1:23 PM, Pu Lehui wrote:
> pm_runtime_get_sync() will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get() to keep usage
> counter balanced.
>
> Signed-off-by: Pu Lehui <pulehui@huawei.com>
> ---
> drivers/i2c/busses/i2c-cadence.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index e4b7f2a951ad..e8eae8725900 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -789,7 +789,7 @@ static int cdns_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
> bool change_role = false;
> #endif
>
> - ret = pm_runtime_get_sync(id->dev);
> + ret = pm_runtime_resume_and_get(id->dev);
> if (ret < 0)
> return ret;
>
> @@ -911,7 +911,7 @@ static int cdns_reg_slave(struct i2c_client *slave)
> if (slave->flags & I2C_CLIENT_TEN)
> return -EAFNOSUPPORT;
>
> - ret = pm_runtime_get_sync(id->dev);
> + ret = pm_runtime_resume_and_get(id->dev);
> if (ret < 0)
> return ret;
>
>
Ravi/Shubhrajyoti: Please take a look at this.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer()
2021-04-08 11:23 [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer() Pu Lehui
2021-04-08 11:30 ` Michal Simek
@ 2021-04-14 7:57 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-04-14 7:57 UTC (permalink / raw)
To: Pu Lehui
Cc: michal.simek, linux-arm-kernel, linux-i2c, linux-kernel,
yangjihong1, zhangjinhao2
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Thu, Apr 08, 2021 at 07:23:52PM +0800, Pu Lehui wrote:
> pm_runtime_get_sync() will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get() to keep usage
> counter balanced.
>
> Signed-off-by: Pu Lehui <pulehui@huawei.com>
Thanks, yet I applied this series now:
http://patchwork.ozlabs.org/project/linux-i2c/list/?series=217733&state=*
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-14 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 11:23 [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer() Pu Lehui
2021-04-08 11:30 ` Michal Simek
2021-04-14 7:57 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).