* [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema
@ 2021-05-24 15:19 Aswath Govindraju
2021-05-24 15:19 ` [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema Aswath Govindraju
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Aswath Govindraju @ 2021-05-24 15:19 UTC (permalink / raw)
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Grygorii Strashko, Aswath Govindraju, Linus Walleij,
Bartosz Golaszewski, Rob Herring, Keerthy, David Lechner,
Sekhar Nori, linux-gpio, devicetree, linux-kernel,
linux-arm-kernel
Convert the davinci GPIO device tree binding documentation to json-schema.
The GPIO hog node names are defined to end with a 'hog' suffix.
All existing GPIO hogs are fixed to follow above naming convention
before changing the binding to avoid dtbs_check warnings.
changes since v2:
- Used gpio-hog.yaml for gpio-hog property
- Added constraints on gpio-hog node name
- Corrected the gpio hog dt node names to align
with the dt-schema
changes since v1:
- combined the individual compatible properties into one enum
- added maxItems and minItems properties for gpio-line-names and
interrupts
- updated the description of interrupts property
- removed the description for properties that are general
- updated the pattern property for gpio hog to indicate any sort
node name based on its usage
- corrected the example wakeup gpio node name
Aswath Govindraju (2):
ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema
dt-bindings: gpio: gpio-davinci: Convert to json-schema
.../devicetree/bindings/gpio/gpio-davinci.txt | 167 ----------------
.../bindings/gpio/gpio-davinci.yaml | 186 ++++++++++++++++++
MAINTAINERS | 2 +-
arch/arm/boot/dts/da850-lego-ev3.dts | 10 +-
4 files changed, 192 insertions(+), 173 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.txt
create mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema
2021-05-24 15:19 [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema Aswath Govindraju
@ 2021-05-24 15:19 ` Aswath Govindraju
2021-05-24 15:52 ` David Lechner
2021-05-24 15:19 ` [PATCH v3 2/2] dt-bindings: gpio: gpio-davinci: Convert to json-schema Aswath Govindraju
2021-06-20 7:29 ` [PATCH v3 0/2] dt-bindings: gpio: davinci: " Aswath Govindraju
2 siblings, 1 reply; 8+ messages in thread
From: Aswath Govindraju @ 2021-05-24 15:19 UTC (permalink / raw)
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Grygorii Strashko, Aswath Govindraju, Linus Walleij,
Bartosz Golaszewski, Rob Herring, Keerthy, Sekhar Nori,
David Lechner, linux-gpio, devicetree, linux-kernel,
linux-arm-kernel
The GPIO hog dt-schema node naming convention expect GPIO hogs node names
to end with a 'hog' suffix.
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
arch/arm/boot/dts/da850-lego-ev3.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/da850-lego-ev3.dts b/arch/arm/boot/dts/da850-lego-ev3.dts
index afd04a423856..1e86cde86406 100644
--- a/arch/arm/boot/dts/da850-lego-ev3.dts
+++ b/arch/arm/boot/dts/da850-lego-ev3.dts
@@ -412,14 +412,14 @@
status = "okay";
/* Don't pull down battery voltage adc io channel */
- batt_volt_en {
+ batt-volt-en-hog {
gpio-hog;
gpios = <6 GPIO_ACTIVE_HIGH>;
output-high;
};
/* Don't impede Bluetooth clock signal */
- bt_clock_en {
+ bt-clock-en-hog {
gpio-hog;
gpios = <5 GPIO_ACTIVE_HIGH>;
input;
@@ -433,19 +433,19 @@
* anything, but they are present in the source code from LEGO.
*/
- bt_pic_en {
+ bt-pic-en-hog {
gpio-hog;
gpios = <51 GPIO_ACTIVE_HIGH>;
output-low;
};
- bt_pic_rst {
+ bt-pic-rst-hog {
gpio-hog;
gpios = <78 GPIO_ACTIVE_HIGH>;
output-high;
};
- bt_pic_cts {
+ bt-pic-cts-hog {
gpio-hog;
gpios = <87 GPIO_ACTIVE_HIGH>;
input;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v3 2/2] dt-bindings: gpio: gpio-davinci: Convert to json-schema
2021-05-24 15:19 [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema Aswath Govindraju
2021-05-24 15:19 ` [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema Aswath Govindraju
@ 2021-05-24 15:19 ` Aswath Govindraju
2021-06-02 19:05 ` Rob Herring
2021-06-21 10:16 ` Bartosz Golaszewski
2021-06-20 7:29 ` [PATCH v3 0/2] dt-bindings: gpio: davinci: " Aswath Govindraju
2 siblings, 2 replies; 8+ messages in thread
From: Aswath Govindraju @ 2021-05-24 15:19 UTC (permalink / raw)
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Grygorii Strashko, Aswath Govindraju, Linus Walleij,
Bartosz Golaszewski, Rob Herring, Keerthy, Sekhar Nori,
David Lechner, linux-gpio, devicetree, linux-kernel,
linux-arm-kernel
Convert gpio-davinci dt-binding documentation from txt to yaml format.
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
.../devicetree/bindings/gpio/gpio-davinci.txt | 167 ----------------
.../bindings/gpio/gpio-davinci.yaml | 186 ++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 187 insertions(+), 168 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.txt
create mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
deleted file mode 100644
index 696ea46227d1..000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
+++ /dev/null
@@ -1,167 +0,0 @@
-Davinci/Keystone GPIO controller bindings
-
-Required Properties:
-- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs
- "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L,
- 66AK2E SoCs
- "ti,k2g-gpio", "ti,keystone-gpio": for 66AK2G
- "ti,am654-gpio", "ti,keystone-gpio": for TI K3 AM654
- "ti,j721e-gpio", "ti,keystone-gpio": for J721E SoCs
- "ti,am64-gpio", "ti,keystone-gpio": for AM64 SoCs
-
-- reg: Physical base address of the controller and the size of memory mapped
- registers.
-
-- gpio-controller : Marks the device node as a gpio controller.
-
-- #gpio-cells : Should be two.
- - first cell is the pin number
- - second cell is used to specify optional parameters (unused)
-
-- interrupts: Array of GPIO interrupt number. Only banked or unbanked IRQs are
- supported at a time.
-
-- ti,ngpio: The number of GPIO pins supported.
-
-- ti,davinci-gpio-unbanked: The number of GPIOs that have an individual interrupt
- line to processor.
-
-- clocks: Should contain the device's input clock, and should be defined as per
- the appropriate clock bindings consumer usage in,
-
- Documentation/devicetree/bindings/clock/keystone-gate.txt
- for 66AK2HK/66AK2L/66AK2E SoCs or,
-
- Documentation/devicetree/bindings/clock/ti,sci-clk.txt
- for 66AK2G SoCs
-
-- clock-names: Name should be "gpio";
-
-Currently clock-names and clocks are needed for all keystone 2 platforms
-Davinci platforms do not have DT clocks as of now.
-
-The GPIO controller also acts as an interrupt controller. It uses the default
-two cells specifier as described in Documentation/devicetree/bindings/
-interrupt-controller/interrupts.txt.
-
-Example:
-
-gpio: gpio@1e26000 {
- compatible = "ti,dm6441-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- reg = <0x226000 0x1000>;
- interrupt-parent = <&intc>;
- interrupts = <42 IRQ_TYPE_EDGE_BOTH 43 IRQ_TYPE_EDGE_BOTH
- 44 IRQ_TYPE_EDGE_BOTH 45 IRQ_TYPE_EDGE_BOTH
- 46 IRQ_TYPE_EDGE_BOTH 47 IRQ_TYPE_EDGE_BOTH
- 48 IRQ_TYPE_EDGE_BOTH 49 IRQ_TYPE_EDGE_BOTH
- 50 IRQ_TYPE_EDGE_BOTH>;
- ti,ngpio = <144>;
- ti,davinci-gpio-unbanked = <0>;
- interrupt-controller;
- #interrupt-cells = <2>;
-};
-
-leds {
- compatible = "gpio-leds";
-
- led1 {
- label = "davinci:green:usr1";
- gpios = <&gpio 10 GPIO_ACTIVE_HIGH>;
- ...
- };
-
- led2 {
- label = "davinci:red:debug1";
- gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
- ...
- };
-};
-
-Example for 66AK2G:
-
-gpio0: gpio@2603000 {
- compatible = "ti,k2g-gpio", "ti,keystone-gpio";
- reg = <0x02603000 0x100>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
- interrupt-controller;
- #interrupt-cells = <2>;
- ti,ngpio = <144>;
- ti,davinci-gpio-unbanked = <0>;
- clocks = <&k2g_clks 0x001b 0x0>;
- clock-names = "gpio";
-};
-
-Example for 66AK2HK/66AK2L/66AK2E:
-
-gpio0: gpio@260bf00 {
- compatible = "ti,keystone-gpio";
- reg = <0x0260bf00 0x100>;
- gpio-controller;
- #gpio-cells = <2>;
- /* HW Interrupts mapped to GPIO pins */
- interrupts = <GIC_SPI 120 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 121 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 122 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 123 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 124 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 125 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 126 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 127 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 128 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 129 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 130 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 131 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 132 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 133 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 134 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 135 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 136 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 137 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 138 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 139 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 140 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 141 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 142 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 143 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 144 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 145 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 146 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 147 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 148 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 149 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 150 IRQ_TYPE_EDGE_RISING>,
- <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>;
- clocks = <&clkgpio>;
- clock-names = "gpio";
- ti,ngpio = <32>;
- ti,davinci-gpio-unbanked = <32>;
-};
-
-Example for K3 AM654:
-
-wkup_gpio0: wkup_gpio0@42110000 {
- compatible = "ti,am654-gpio", "ti,keystone-gpio";
- reg = <0x42110000 0x100>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-parent = <&intr_wkup_gpio>;
- interrupts = <59 128>, <59 129>, <59 130>, <59 131>;
- interrupt-controller;
- #interrupt-cells = <2>;
- ti,ngpio = <56>;
- ti,davinci-gpio-unbanked = <0>;
- clocks = <&k3_clks 59 0>;
- clock-names = "gpio";
-};
diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
new file mode 100644
index 000000000000..4016f6cd997f
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
@@ -0,0 +1,186 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/gpio-davinci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GPIO controller for Davinci and keystone devices
+
+maintainers:
+ - Keerthy <j-keerthy@ti.com>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - ti,k2g-gpio
+ - ti,am654-gpio
+ - ti,j721e-gpio
+ - ti,am64-gpio
+ - const: ti,keystone-gpio
+
+ - items:
+ - enum:
+ - ti,dm6441-gpio
+ - ti,keystone-gpio
+
+ reg:
+ maxItems: 1
+
+ gpio-controller: true
+
+ gpio-ranges: true
+
+ gpio-line-names:
+ description: strings describing the names of each gpio line.
+ minItems: 1
+ maxItems: 100
+
+ "#gpio-cells":
+ const: 2
+ description:
+ first cell is the pin number and second cell is used to specify optional parameters (unused).
+
+ interrupts:
+ description:
+ The interrupts are specified as per the interrupt parent. Only banked
+ or unbanked IRQs are supported at a time. If the interrupts are
+ banked then provide list of interrupts corresponding to each bank, else
+ provide the list of interrupts for each gpio.
+ minItems: 1
+ maxItems: 100
+
+ ti,ngpio:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: The number of GPIO pins supported consecutively.
+ minimum: 1
+
+ ti,davinci-gpio-unbanked:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: The number of GPIOs that have an individual interrupt line to processor.
+ minimum: 0
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ const: gpio
+
+ interrupt-controller: true
+
+ power-domains:
+ maxItems: 1
+
+ "#interrupt-cells":
+ const: 2
+
+patternProperties:
+ "^(.+-hog(-[0-9]+)?)$":
+ type: object
+
+ required:
+ - gpio-hog
+
+required:
+ - compatible
+ - reg
+ - gpio-controller
+ - "#gpio-cells"
+ - interrupts
+ - ti,ngpio
+ - ti,davinci-gpio-unbanked
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include<dt-bindings/interrupt-controller/arm-gic.h>
+
+ gpio0: gpio@2603000 {
+ compatible = "ti,k2g-gpio", "ti,keystone-gpio";
+ reg = <0x02603000 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <144>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k2g_clks 0x001b 0x0>;
+ clock-names = "gpio";
+ };
+
+ - |
+ #include<dt-bindings/interrupt-controller/arm-gic.h>
+
+ gpio1: gpio@260bf00 {
+ compatible = "ti,keystone-gpio";
+ reg = <0x0260bf00 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ /* HW Interrupts mapped to GPIO pins */
+ interrupts = <GIC_SPI 120 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 121 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 122 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 123 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 124 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 125 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 126 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 127 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 128 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 129 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 130 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 131 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 132 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 133 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 134 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 135 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 136 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 137 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 138 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 139 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 140 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 141 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 142 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 143 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 144 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 145 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 146 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 147 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 148 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 149 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 150 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>;
+ clocks = <&clkgpio>;
+ clock-names = "gpio";
+ ti,ngpio = <32>;
+ ti,davinci-gpio-unbanked = <32>;
+ };
+
+ - |
+ wkup_gpio0: gpio0@42110000 {
+ compatible = "ti,am654-gpio", "ti,keystone-gpio";
+ reg = <0x42110000 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&intr_wkup_gpio>;
+ interrupts = <60>, <61>, <62>, <63>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <56>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k3_clks 59 0>;
+ clock-names = "gpio";
+ };
+
diff --git a/MAINTAINERS b/MAINTAINERS
index a2f94f095832..b0a185c7016a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18304,7 +18304,7 @@ TI DAVINCI SERIES GPIO DRIVER
M: Keerthy <j-keerthy@ti.com>
L: linux-gpio@vger.kernel.org
S: Maintained
-F: Documentation/devicetree/bindings/gpio/gpio-davinci.txt
+F: Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
F: drivers/gpio/gpio-davinci.c
TI DAVINCI SERIES MEDIA DRIVER
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema
2021-05-24 15:19 ` [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema Aswath Govindraju
@ 2021-05-24 15:52 ` David Lechner
0 siblings, 0 replies; 8+ messages in thread
From: David Lechner @ 2021-05-24 15:52 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Grygorii Strashko, Linus Walleij, Bartosz Golaszewski,
Rob Herring, Keerthy, Sekhar Nori, linux-gpio, devicetree,
linux-kernel, linux-arm-kernel
On 5/24/21 10:19 AM, Aswath Govindraju wrote:
> The GPIO hog dt-schema node naming convention expect GPIO hogs node names
> to end with a 'hog' suffix.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
Acked-by: David Lechner <david@lechnology.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: gpio: gpio-davinci: Convert to json-schema
2021-05-24 15:19 ` [PATCH v3 2/2] dt-bindings: gpio: gpio-davinci: Convert to json-schema Aswath Govindraju
@ 2021-06-02 19:05 ` Rob Herring
2021-06-21 10:16 ` Bartosz Golaszewski
1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2021-06-02 19:05 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Sekhar Nori, linux-gpio, Lokesh Vutla, Bartosz Golaszewski,
Linus Walleij, Vignesh Raghavendra, Rob Herring, Keerthy,
Kishon Vijay Abraham I, linux-arm-kernel, devicetree,
David Lechner, linux-kernel, Grygorii Strashko
On Mon, 24 May 2021 20:49:54 +0530, Aswath Govindraju wrote:
> Convert gpio-davinci dt-binding documentation from txt to yaml format.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> .../devicetree/bindings/gpio/gpio-davinci.txt | 167 ----------------
> .../bindings/gpio/gpio-davinci.yaml | 186 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 187 insertions(+), 168 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema
2021-05-24 15:19 [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema Aswath Govindraju
2021-05-24 15:19 ` [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema Aswath Govindraju
2021-05-24 15:19 ` [PATCH v3 2/2] dt-bindings: gpio: gpio-davinci: Convert to json-schema Aswath Govindraju
@ 2021-06-20 7:29 ` Aswath Govindraju
2021-06-21 11:48 ` Bartosz Golaszewski
2 siblings, 1 reply; 8+ messages in thread
From: Aswath Govindraju @ 2021-06-20 7:29 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Grygorii Strashko, Rob Herring, Keerthy, David Lechner,
Sekhar Nori, linux-gpio, devicetree, linux-kernel,
linux-arm-kernel
Hi Bart, Linus,
On 24/05/21 8:49 pm, Aswath Govindraju wrote:
> Convert the davinci GPIO device tree binding documentation to json-schema.
> The GPIO hog node names are defined to end with a 'hog' suffix.
>
> All existing GPIO hogs are fixed to follow above naming convention
> before changing the binding to avoid dtbs_check warnings.
>
> changes since v2:
> - Used gpio-hog.yaml for gpio-hog property
> - Added constraints on gpio-hog node name
> - Corrected the gpio hog dt node names to align
> with the dt-schema
>
May I know if the following series is okay to be merged ?
Thanks,
Aswath
> changes since v1:
> - combined the individual compatible properties into one enum
> - added maxItems and minItems properties for gpio-line-names and
> interrupts
> - updated the description of interrupts property
> - removed the description for properties that are general
> - updated the pattern property for gpio hog to indicate any sort
> node name based on its usage
> - corrected the example wakeup gpio node name
>
> Aswath Govindraju (2):
> ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema
> dt-bindings: gpio: gpio-davinci: Convert to json-schema
>
> .../devicetree/bindings/gpio/gpio-davinci.txt | 167 ----------------
> .../bindings/gpio/gpio-davinci.yaml | 186 ++++++++++++++++++
> MAINTAINERS | 2 +-
> arch/arm/boot/dts/da850-lego-ev3.dts | 10 +-
> 4 files changed, 192 insertions(+), 173 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: gpio: gpio-davinci: Convert to json-schema
2021-05-24 15:19 ` [PATCH v3 2/2] dt-bindings: gpio: gpio-davinci: Convert to json-schema Aswath Govindraju
2021-06-02 19:05 ` Rob Herring
@ 2021-06-21 10:16 ` Bartosz Golaszewski
1 sibling, 0 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2021-06-21 10:16 UTC (permalink / raw)
To: Aswath Govindraju
Cc: Lokesh Vutla, Vignesh Raghavendra, Kishon Vijay Abraham I,
Grygorii Strashko, Linus Walleij, Rob Herring, Keerthy,
Sekhar Nori, David Lechner, linux-gpio, linux-devicetree, LKML,
arm-soc
On Mon, May 24, 2021 at 5:20 PM Aswath Govindraju <a-govindraju@ti.com> wrote:
>
> Convert gpio-davinci dt-binding documentation from txt to yaml format.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
Patch applied, thanks!
Bart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema
2021-06-20 7:29 ` [PATCH v3 0/2] dt-bindings: gpio: davinci: " Aswath Govindraju
@ 2021-06-21 11:48 ` Bartosz Golaszewski
0 siblings, 0 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2021-06-21 11:48 UTC (permalink / raw)
To: Aswath Govindraju, Sekhar Nori
Cc: Linus Walleij, Lokesh Vutla, Vignesh Raghavendra,
Kishon Vijay Abraham I, Grygorii Strashko, Rob Herring, Keerthy,
David Lechner, linux-gpio, linux-devicetree, LKML, arm-soc
On Sun, Jun 20, 2021 at 9:29 AM Aswath Govindraju <a-govindraju@ti.com> wrote:
>
> Hi Bart, Linus,
>
> On 24/05/21 8:49 pm, Aswath Govindraju wrote:
> > Convert the davinci GPIO device tree binding documentation to json-schema.
> > The GPIO hog node names are defined to end with a 'hog' suffix.
> >
> > All existing GPIO hogs are fixed to follow above naming convention
> > before changing the binding to avoid dtbs_check warnings.
> >
> > changes since v2:
> > - Used gpio-hog.yaml for gpio-hog property
> > - Added constraints on gpio-hog node name
> > - Corrected the gpio hog dt node names to align
> > with the dt-schema
> >
>
> May I know if the following series is okay to be merged ?
>
> Thanks,
> Aswath
>
I applied the dt-bindings patch. Sekhar normally takes DTS patches for davinci.
Bart
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-06-21 11:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 15:19 [PATCH v3 0/2] dt-bindings: gpio: davinci: Convert to json-schema Aswath Govindraju
2021-05-24 15:19 ` [PATCH v3 1/2] ARM: dts: da850-lego-ev3: align GPIO hog names with dt-schema Aswath Govindraju
2021-05-24 15:52 ` David Lechner
2021-05-24 15:19 ` [PATCH v3 2/2] dt-bindings: gpio: gpio-davinci: Convert to json-schema Aswath Govindraju
2021-06-02 19:05 ` Rob Herring
2021-06-21 10:16 ` Bartosz Golaszewski
2021-06-20 7:29 ` [PATCH v3 0/2] dt-bindings: gpio: davinci: " Aswath Govindraju
2021-06-21 11:48 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).