From: Masami Hiramatsu <mhiramat@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: acme@kernel.org, jolsa@redhat.com, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, aneesh.kumar@linux.ibm.com
Subject: Re: [PATCH] perf probe: Provide more detail with relocation warning
Date: Tue, 25 May 2021 21:48:58 +0900 [thread overview]
Message-ID: <20210525214858.33a66846ac09e499c3268a63@kernel.org> (raw)
In-Reply-To: <20210525043744.193297-1-ravi.bangoria@linux.ibm.com>
On Tue, 25 May 2021 10:07:44 +0530
Ravi Bangoria <ravi.bangoria@linux.ibm.com> wrote:
> When run as normal user with default sysctl kernel.kptr_restrict=0
> and kernel.perf_event_paranoid=2, perf probe fails with:
>
> $ ./perf probe move_page_tables
> Relocated base symbol is not found!
>
> The warning message is not much informative. The reason perf fails
> is because /proc/kallsyms is restricted by perf_event_paranoid=2
> for normal user and thus perf fails to read relocated address of
> the base symbol.
>
> Tweaking kptr_restrict and perf_event_paranoid can change the
> behavior of perf probe. Also, running as root or privileged user
> works too. Add these details in the warning message.
>
> Plus, kmap->ref_reloc_sym might not be always set even if
> host_machine is initialized. Above is the example of the same.
> Remove that comment.
Yes, those are restricted in some cases. Anyway without priviledged
(super) user, perf probe can not set the probe in ftrace.
Hmm, I think it should check the effective user-id at first. If it
is not super user and the action will access tracefs and kallsyms,
it should warn at that point.
Thank you,
>
> Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> ---
> tools/perf/util/probe-event.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index a78c8d59a555..3a7649835ec9 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -108,7 +108,6 @@ void exit_probe_symbol_maps(void)
>
> static struct ref_reloc_sym *kernel_get_ref_reloc_sym(struct map **pmap)
> {
> - /* kmap->ref_reloc_sym should be set if host_machine is initialized */
> struct kmap *kmap;
> struct map *map = machine__kernel_map(host_machine);
>
> @@ -819,7 +818,10 @@ post_process_kernel_probe_trace_events(struct probe_trace_event *tevs,
>
> reloc_sym = kernel_get_ref_reloc_sym(&map);
> if (!reloc_sym) {
> - pr_warning("Relocated base symbol is not found!\n");
> + pr_warning("Relocated base symbol is not found! "
> + "Check /proc/sys/kernel/kptr_restrict\n"
> + "and /proc/sys/kernel/perf_event_paranoid. "
> + "Or run as privileged perf user.\n\n");
> return -EINVAL;
> }
>
> @@ -3025,7 +3027,10 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,
> (!pp->retprobe || kretprobe_offset_is_supported())) {
> reloc_sym = kernel_get_ref_reloc_sym(NULL);
> if (!reloc_sym) {
> - pr_warning("Relocated base symbol is not found!\n");
> + pr_warning("Relocated base symbol is not found! "
> + "Check /proc/sys/kernel/kptr_restrict\n"
> + "and /proc/sys/kernel/perf_event_paranoid. "
> + "Or run as privileged perf user.\n\n");
> ret = -EINVAL;
> goto out;
> }
> --
> 2.31.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-05-25 12:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 4:37 [PATCH] perf probe: Provide more detail with relocation warning Ravi Bangoria
2021-05-25 12:48 ` Masami Hiramatsu [this message]
2021-05-26 4:53 ` Ravi Bangoria
2021-05-26 6:33 ` Masami Hiramatsu
2021-05-26 12:56 ` Arnaldo Carvalho de Melo
2021-05-26 14:20 ` Masami Hiramatsu
2021-06-02 11:52 ` Arnaldo Carvalho de Melo
2021-06-02 12:12 ` Masami Hiramatsu
2021-06-02 13:15 ` Arnaldo Carvalho de Melo
2021-05-26 9:01 ` [PATCH] tools/perf: doc: Add permission and sysctl notice Masami Hiramatsu
2021-05-26 9:50 ` Ravi Bangoria
2021-05-26 13:16 ` Masami Hiramatsu
2021-05-26 14:51 ` [PATCH v2] " Masami Hiramatsu
2021-06-02 11:53 ` Arnaldo Carvalho de Melo
2021-06-02 13:51 ` Ravi Bangoria
2021-06-04 13:25 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525214858.33a66846ac09e499c3268a63@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).