* [PATCH] clk: socfpga: clk-pll: Remove unused variable 'rc'
@ 2021-06-09 7:37 Jian Xin
2021-06-28 0:33 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Jian Xin @ 2021-06-09 7:37 UTC (permalink / raw)
To: dinguyen, mturquette, sboyd; +Cc: linux-clk, linux-kernel, Jian Xin
From: Jian Xin <xinjian@yulong.com>
Fix the following build warning:
drivers/clk/socfpga/clk-pll.c: In function ‘__socfpga_pll_init’:
drivers/clk/socfpga/clk-pll.c:83:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Jian Xin <xinjian@yulong.com>
---
drivers/clk/socfpga/clk-pll.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/socfpga/clk-pll.c b/drivers/clk/socfpga/clk-pll.c
index dcb573d44034..127cc849c5ee 100644
--- a/drivers/clk/socfpga/clk-pll.c
+++ b/drivers/clk/socfpga/clk-pll.c
@@ -80,7 +80,6 @@ static __init struct clk_hw *__socfpga_pll_init(struct device_node *node,
const char *parent_name[SOCFPGA_MAX_PARENTS];
struct clk_init_data init;
struct device_node *clkmgr_np;
- int rc;
int err;
of_property_read_u32(node, "reg", ®);
@@ -114,7 +113,7 @@ static __init struct clk_hw *__socfpga_pll_init(struct device_node *node,
kfree(pll_clk);
return ERR_PTR(err);
}
- rc = of_clk_add_provider(node, of_clk_src_simple_get, hw_clk);
+ of_clk_add_provider(node, of_clk_src_simple_get, hw_clk);
return hw_clk;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: socfpga: clk-pll: Remove unused variable 'rc'
2021-06-09 7:37 [PATCH] clk: socfpga: clk-pll: Remove unused variable 'rc' Jian Xin
@ 2021-06-28 0:33 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2021-06-28 0:33 UTC (permalink / raw)
To: Jian Xin, dinguyen, mturquette; +Cc: linux-clk, linux-kernel, Jian Xin
Quoting Jian Xin (2021-06-09 00:37:42)
> From: Jian Xin <xinjian@yulong.com>
>
> Fix the following build warning:
> drivers/clk/socfpga/clk-pll.c: In function ‘__socfpga_pll_init’:
> drivers/clk/socfpga/clk-pll.c:83:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Jian Xin <xinjian@yulong.com>
> ---
Applied to clk-next but it would be better to check the return value and
fail properly.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-28 0:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 7:37 [PATCH] clk: socfpga: clk-pll: Remove unused variable 'rc' Jian Xin
2021-06-28 0:33 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).