From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Krzysztof Hałasa" <khalasa@piap.pl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor
Date: Thu, 24 Jun 2021 13:10:48 +0200 [thread overview]
Message-ID: <20210624131048.1272f272@coco.lan> (raw)
In-Reply-To: <YNHQDNdpxcY8+IV2@pendragon.ideasonboard.com>
Em Tue, 22 Jun 2021 14:57:00 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> Hi Krzysztof,
>
> Thank you for the patch.
>
> On Tue, Jun 22, 2021 at 01:18:55PM +0200, Krzysztof Hałasa wrote:
> > Changes from v1:
> > - added power management (power supplies, no chip initialization in
> > probe()).
> > - added [HV]BLANK v4l2 ctrl interface (the "interval" interface is
> > still implemented for better timing control)
> > - many fixes, including ones requested by Laurent Pinchart.
> >
> > The driver has been extensively tested in an i.MX6-based system.
> >
> > Not yet signed off - this will change of course. Please do not merge
> > yet, however comments about being ready (or not) to be merged are
> > welcome.
>
> To spend time reviewing this code, I want to know it will be mergeable,
> and that requires a SoB line. That's a blocker I'm afraid.
If:
- the driver is in good shape, e. g. no coding style issues,
it uses the right kAPI at the right way, etc;
- the driver is based on the current media_tree.git tree;
- if you're willing to be responsible during the review process;
- you would provide maintainance support for the driver if
bugs are reported;
- the driver has a valid Signed-off-by;
then the driver is mergeable.
Media maintainers need a SoB in order to be able to review, as
driver review takes a lot of time and efforts from reviewers, and
the time they spend reviewing a driver prevents them to do their
(paid) work.
That's said, on a very quick check, it sounds that this driver requires
some work. For instance, it is based on an v4l2_subdev_pad_config,
which was recently replaced upstream.
Thanks,
Mauro
next prev parent reply other threads:[~2021-06-24 11:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 11:18 [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor Krzysztof Hałasa
2021-06-22 11:57 ` Laurent Pinchart
2021-06-23 4:21 ` Krzysztof Hałasa
2021-06-23 4:31 ` Laurent Pinchart
2021-06-23 5:28 ` Krzysztof Hałasa
2021-06-23 13:17 ` Laurent Pinchart
2021-06-23 14:27 ` Kieran Bingham
2021-06-24 4:57 ` Krzysztof Hałasa
2021-06-24 12:10 ` Laurent Pinchart
2021-06-24 12:39 ` Greg KH
2021-06-24 13:22 ` Krzysztof Hałasa
2021-06-24 13:29 ` Greg KH
2021-06-24 14:17 ` Krzysztof Hałasa
2021-06-24 14:31 ` Greg KH
2021-06-24 13:34 ` Laurent Pinchart
2021-06-24 14:42 ` Greg KH
2021-06-25 6:03 ` Krzysztof Hałasa
2021-06-25 6:59 ` Greg KH
2021-06-24 11:10 ` Mauro Carvalho Chehab [this message]
2021-06-24 13:51 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624131048.1272f272@coco.lan \
--to=mchehab@kernel.org \
--cc=khalasa@piap.pl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).