From: Greg KH <gregkh@linuxfoundation.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Krzysztof Hałasa" <khalasa@piap.pl>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor
Date: Thu, 24 Jun 2021 16:42:41 +0200 [thread overview]
Message-ID: <YNSZ4fbboJokxZSx@kroah.com> (raw)
In-Reply-To: <YNSJzgJ5xu2j+U2p@pendragon.ideasonboard.com>
On Thu, Jun 24, 2021 at 04:34:06PM +0300, Laurent Pinchart wrote:
> On Thu, Jun 24, 2021 at 03:22:48PM +0200, Krzysztof Hałasa wrote:
> > Hi Greg,
> >
> > Greg KH <gregkh@linuxfoundation.org> writes:
> >
> > > +// SPDX-License-Identifier: GPL-2.0
> >
> > > Putting the above line on a file _IS_ a legal declaration that the file
> > > is released under GPL-2.0. It's pretty simple :)
>
> Greg, on a side note, the discussion originated from
> https://lore.kernel.org/linux-media/m3r1gt5hzm.fsf@t19.piap.pl/. I'll
> quote Krzysztof so the discussion doesn't get split across multiple
> places:
>
> > > To spend time reviewing this code, I want to know it will be mergeable,
> > > and that requires a SoB line. That's a blocker I'm afraid.
> >
> > So how do you propose to solve the situation, in which my driver is
> > rejected, but another persor takes it, makes changes (btw breaking it),
> > and presents it as their own, and it's accepted? This is a paid work and
> > I'm required to put in my employer's copyright over the code.
> > I could have made this error once - but no more.
> >
> > The code will be mergeable, as I already wrote. Why would I bother
> > otherwise? But I cannot let that history to repeat itself.
>
> Your opinion on this would be valuable too.
I would not waste my time on code that does not have a signed-off-by on
it, otherwise the developer is obviously saying they do not want to
merge this as-is. And I think we all have plenty of code from
developers that actually want to have their patches merged.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-24 14:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 11:18 [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor Krzysztof Hałasa
2021-06-22 11:57 ` Laurent Pinchart
2021-06-23 4:21 ` Krzysztof Hałasa
2021-06-23 4:31 ` Laurent Pinchart
2021-06-23 5:28 ` Krzysztof Hałasa
2021-06-23 13:17 ` Laurent Pinchart
2021-06-23 14:27 ` Kieran Bingham
2021-06-24 4:57 ` Krzysztof Hałasa
2021-06-24 12:10 ` Laurent Pinchart
2021-06-24 12:39 ` Greg KH
2021-06-24 13:22 ` Krzysztof Hałasa
2021-06-24 13:29 ` Greg KH
2021-06-24 14:17 ` Krzysztof Hałasa
2021-06-24 14:31 ` Greg KH
2021-06-24 13:34 ` Laurent Pinchart
2021-06-24 14:42 ` Greg KH [this message]
2021-06-25 6:03 ` Krzysztof Hałasa
2021-06-25 6:59 ` Greg KH
2021-06-24 11:10 ` Mauro Carvalho Chehab
2021-06-24 13:51 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNSZ4fbboJokxZSx@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=khalasa@piap.pl \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).