* [PATCH 0/2] usb: renesas-xhci: Cleanups
@ 2021-07-18 1:51 Moritz Fischer
2021-07-18 1:51 ` [PATCH 1/2] usb: xhci-renesas: Minor coding style cleanup Moritz Fischer
2021-07-18 1:51 ` [PATCH 2/2] usb: renesas-xhci: Remove renesas_xhci_pci_exit() Moritz Fischer
0 siblings, 2 replies; 3+ messages in thread
From: Moritz Fischer @ 2021-07-18 1:51 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-usb, moritzf, mathias.nyman, gregkh, Moritz Fischer
While looking through the driver code I ran into two minor things.
The first one is a simple if (err == 0) -> if (!err) change.
The second one removes an empty(?) function that seems to have been
around since the beginning (and always has been empty).
Moritz Fischer (2):
usb: xhci-renesas: Minor coding style cleanup
usb: renesas-xhci: Remove renesas_xhci_pci_exit()
drivers/usb/host/xhci-pci-renesas.c | 7 +------
drivers/usb/host/xhci-pci.c | 2 --
drivers/usb/host/xhci-pci.h | 3 ---
3 files changed, 1 insertion(+), 11 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] usb: xhci-renesas: Minor coding style cleanup
2021-07-18 1:51 [PATCH 0/2] usb: renesas-xhci: Cleanups Moritz Fischer
@ 2021-07-18 1:51 ` Moritz Fischer
2021-07-18 1:51 ` [PATCH 2/2] usb: renesas-xhci: Remove renesas_xhci_pci_exit() Moritz Fischer
1 sibling, 0 replies; 3+ messages in thread
From: Moritz Fischer @ 2021-07-18 1:51 UTC (permalink / raw)
To: linux-kernel
Cc: linux-usb, moritzf, mathias.nyman, gregkh, Moritz Fischer, Vinod Koul
Change an explicit err == 0 to !err. No functional change.
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/usb/host/xhci-pci-renesas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c
index 1da647961c25..327f6a6d5672 100644
--- a/drivers/usb/host/xhci-pci-renesas.c
+++ b/drivers/usb/host/xhci-pci-renesas.c
@@ -595,7 +595,7 @@ int renesas_xhci_check_request_fw(struct pci_dev *pdev,
err = renesas_fw_check_running(pdev);
/* Continue ahead, if the firmware is already running. */
- if (err == 0)
+ if (!err)
return 0;
if (err != 1)
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] usb: renesas-xhci: Remove renesas_xhci_pci_exit()
2021-07-18 1:51 [PATCH 0/2] usb: renesas-xhci: Cleanups Moritz Fischer
2021-07-18 1:51 ` [PATCH 1/2] usb: xhci-renesas: Minor coding style cleanup Moritz Fischer
@ 2021-07-18 1:51 ` Moritz Fischer
1 sibling, 0 replies; 3+ messages in thread
From: Moritz Fischer @ 2021-07-18 1:51 UTC (permalink / raw)
To: linux-kernel
Cc: linux-usb, moritzf, mathias.nyman, gregkh, Moritz Fischer, Vinod Koul
Remove empty function renesas_xhci_pci_exit() that does not
actually do anything.
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/usb/host/xhci-pci-renesas.c | 5 -----
drivers/usb/host/xhci-pci.c | 2 --
drivers/usb/host/xhci-pci.h | 3 ---
3 files changed, 10 deletions(-)
diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c
index 327f6a6d5672..1ebacc42a552 100644
--- a/drivers/usb/host/xhci-pci-renesas.c
+++ b/drivers/usb/host/xhci-pci-renesas.c
@@ -620,9 +620,4 @@ int renesas_xhci_check_request_fw(struct pci_dev *pdev,
}
EXPORT_SYMBOL_GPL(renesas_xhci_check_request_fw);
-void renesas_xhci_pci_exit(struct pci_dev *dev)
-{
-}
-EXPORT_SYMBOL_GPL(renesas_xhci_pci_exit);
-
MODULE_LICENSE("GPL v2");
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 18c2bbddf080..4456ba338b74 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -449,8 +449,6 @@ static void xhci_pci_remove(struct pci_dev *dev)
struct xhci_hcd *xhci;
xhci = hcd_to_xhci(pci_get_drvdata(dev));
- if (xhci->quirks & XHCI_RENESAS_FW_QUIRK)
- renesas_xhci_pci_exit(dev);
xhci->xhc_state |= XHCI_STATE_REMOVING;
diff --git a/drivers/usb/host/xhci-pci.h b/drivers/usb/host/xhci-pci.h
index acd7cf0a1706..cb9a8f331a44 100644
--- a/drivers/usb/host/xhci-pci.h
+++ b/drivers/usb/host/xhci-pci.h
@@ -7,7 +7,6 @@
#if IS_ENABLED(CONFIG_USB_XHCI_PCI_RENESAS)
int renesas_xhci_check_request_fw(struct pci_dev *dev,
const struct pci_device_id *id);
-void renesas_xhci_pci_exit(struct pci_dev *dev);
#else
static int renesas_xhci_check_request_fw(struct pci_dev *dev,
@@ -16,8 +15,6 @@ static int renesas_xhci_check_request_fw(struct pci_dev *dev,
return 0;
}
-static void renesas_xhci_pci_exit(struct pci_dev *dev) { };
-
#endif
struct xhci_driver_data {
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-18 1:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-18 1:51 [PATCH 0/2] usb: renesas-xhci: Cleanups Moritz Fischer
2021-07-18 1:51 ` [PATCH 1/2] usb: xhci-renesas: Minor coding style cleanup Moritz Fischer
2021-07-18 1:51 ` [PATCH 2/2] usb: renesas-xhci: Remove renesas_xhci_pci_exit() Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).